Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 11140025: Enable incremental code flushing. (Closed)

Created:
8 years, 2 months ago by Michael Starzinger
Modified:
8 years, 2 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Enable incremental code flushing. This enables code flushing even with incremental marking enabled and fully shares the function link field in JSFunctions between candidates for code flushing and the optimized functions list. If a candidate for code flushing gets optimized, it will be evicted from the candidates list. R=ulan@chromium.org BUG=v8:1609 Committed: https://code.google.com/p/v8/source/detail?r=12796

Patch Set 1 #

Patch Set 2 : Remove debugging code. #

Total comments: 2

Patch Set 3 : Prevent recording a flushing candidate twice. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -66 lines) Patch
M src/contexts.cc View 2 chunks +10 lines, -2 lines 0 comments Download
M src/heap.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/mark-compact.h View 1 2 3 chunks +22 lines, -18 lines 0 comments Download
M src/mark-compact.cc View 1 2 6 chunks +33 lines, -21 lines 0 comments Download
M src/runtime.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M test/cctest/test-heap.cc View 5 chunks +90 lines, -24 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Starzinger
8 years, 2 months ago (2012-10-15 14:21:02 UTC) #1
ulan
Only on question, otherwise looks good. https://codereview.chromium.org/11140025/diff/2001/src/heap.cc File src/heap.cc (right): https://codereview.chromium.org/11140025/diff/2001/src/heap.cc#newcode411 src/heap.cc:411: if (isolate_->debug()->IsLoaded() || ...
8 years, 2 months ago (2012-10-16 08:09:31 UTC) #2
Michael Starzinger
https://codereview.chromium.org/11140025/diff/2001/src/heap.cc File src/heap.cc (right): https://codereview.chromium.org/11140025/diff/2001/src/heap.cc#newcode411 src/heap.cc:411: if (isolate_->debug()->IsLoaded() || isolate_->debug()->has_break_points()) { On 2012/10/16 08:09:31, ulan ...
8 years, 2 months ago (2012-10-16 08:27:54 UTC) #3
ulan
8 years, 2 months ago (2012-10-16 08:34:44 UTC) #4
> When the condition becomes true, the debugger will trigger a GC with
> kMakeHeapIterable, which imples kAbortIncrementalMarking. So it's implicitly
> aborted. But you are right, this requires a comment either here or in the
> debugger. Will add the comment.

Thanks for clarification, LGTM.

Powered by Google App Engine
This is Rietveld 408576698