Enable incremental code flushing.

Enable incremental code flushing.

This enables code flushing even with incremental marking enabled and
fully shares the function link field in JSFunctions between candidates
for code flushing and the optimized functions list. If a candidate for
code flushing gets optimized, it will be evicted from the candidates
list.

R=ulan@chromium.org
BUG=v8:1609
Committed: https://code.google.com/p/v8/source/detail?r=12796

[ulan, 2012-10-16 08:09:31]

Only on question, otherwise looks good.

https://codereview.chromium.org/11140025/diff/2001/src/heap.cc
File src/heap.cc (right):

https://codereview.chromium.org/11140025/diff/2001/src/heap.cc#newcode411
src/heap.cc:411: if (isolate_->debug()->IsLoaded() ||
isolate_->debug()->has_break_points()) {
What if this condition becomes true during incremental marking after we enabled
code flushing? Will it break the debugger?

[Michael Starzinger, 2012-10-16 08:27:54]

https://codereview.chromium.org/11140025/diff/2001/src/heap.cc
File src/heap.cc (right):

https://codereview.chromium.org/11140025/diff/2001/src/heap.cc#newcode411
src/heap.cc:411: if (isolate_->debug()->IsLoaded() ||
isolate_->debug()->has_break_points()) {
On 2012/10/16 08:09:31, ulan wrote:
> What if this condition becomes true during incremental marking after we
enabled
> code flushing? Will it break the debugger?

When the condition becomes true, the debugger will trigger a GC with
kMakeHeapIterable, which imples kAbortIncrementalMarking. So it's implicitly
aborted. But you are right, this requires a comment either here or in the
debugger. Will add the comment.

[ulan, 2012-10-16 08:34:44]

> When the condition becomes true, the debugger will trigger a GC with
> kMakeHeapIterable, which imples kAbortIncrementalMarking. So it's implicitly
> aborted. But you are right, this requires a comment either here or in the
> debugger. Will add the comment.

Thanks for clarification, LGTM.