Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(12)

Issue 1113973002: Remove FrameView::m_inProgrammaticScroll and related plumbing. (Closed)

Created:
5 years ago by skobes
Modified:
5 years ago
Reviewers:
dsinclair, pdr.
CC:
blink-reviews, blink-reviews-events_chromium.org, bokan, dglazkov+blink, eae+blinkwatch, Michael van Ouwerkerk
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove FrameView::m_inProgrammaticScroll and related plumbing. It seems this field only exists so that FrameView::setWasScrolledByUser can say "oh, you didn't really mean to do that". With this patch we no longer call setWasScrolledByUser(true) from FrameView::scrollPositionChanged, which handles both user and programmatic scrolls, and instead call it only for actual user scrolls. EventHandler was already doing this in many cases. This happens to revert the effects of http://crrev.com/16254006, which I think are no longer needed (aelias thinks it was for http://crbug.com/165317). Not having to update m_inProgrammaticScroll simplifies other scrolling changes, such as RootFrameViewport and root layer scrolling. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194786

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -64 lines) Patch
M Source/core/frame/FrameView.h View 3 chunks +0 lines, -5 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 6 chunks +0 lines, -20 lines 0 comments Download
M Source/core/loader/FrameLoader.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/page/EventHandler.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M Source/web/WebViewImpl.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/web/tests/ProgrammaticScrollTest.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 3 chunks +30 lines, -30 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
skobes
5 years ago (2015-04-30 16:02:53 UTC) #3
dsinclair
lgtm +pdr for Source/web
5 years ago (2015-05-01 02:06:13 UTC) #5
pdr.
On 2015/05/01 at 02:06:13, dsinclair wrote: > lgtm > > +pdr for Source/web LGTM
5 years ago (2015-05-01 02:07:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1113973002/20001
5 years ago (2015-05-01 04:40:31 UTC) #8
commit-bot: I haz the power
5 years ago (2015-05-01 04:58:33 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194786

Powered by Google App Engine
This is Rietveld 408576698