Issue 111393006: Revert of Roll swarming_client @ 9cc42c3d4d.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 111393006: Revert of Roll swarming_client @ 9cc42c3d4d. (Closed)

Created:
7 years ago by ckocagil

Modified:
7 years ago

Reviewers:
bulach, Vadim Sh., M-A Ruel, frankf

CC:
chromium-reviews, Nico, csharp

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Revert of https://codereview.chromium.org/105933002/ Reason for revert: tree breakage: "runisolatedtest.py:108 ERROR Unexpected isolate version 1.2" TBR=vadimsh@chromium.org,bulach@chromium.org,frankf@chromium.org,maruel@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240243

Patch Set 1 #

Created: 7 years ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -11 lines)			Patch
M	DEPS	View	1 chunk	+1 line, -1 line	0 comments	Download
M	build/android/pylib/gtest/setup.py	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	build/isolate.gypi	View	4 chunks	+4 lines, -8 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ckocagil@chromium.org/111393006/1

7 years ago (2013-12-12 02:54:02 UTC) #2

M-A Ruel

On 2013/12/12 02:58:02, I haz the power (commit-bot) wrote: > Change committed as 240243 Please ...

7 years ago (2013-12-12 14:29:58 UTC) #4

M-A Ruel

7 years ago (2013-12-12 14:38:47 UTC) #5

Message was sent while issue was closed.

On 2013/12/12 14:29:58, M-A Ruel wrote:
> On 2013/12/12 02:58:02, I haz the power (commit-bot) wrote:
> > Change committed as 240243
> 
> Please be more explicit in the revert reason. I have a hard time finding a log
> where this reproduce.

I read the code and I was enlightened.

Expand Messages | Collapse Messages