Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 1113913003: Allow Raw Input gamepads to persist across page refreshes (Closed)

Created:
5 years, 7 months ago by bajones
Modified:
5 years, 7 months ago
Reviewers:
scottmg
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@shield_mapping
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow Raw Input gamepads to persist across page refreshes The problem was that we were clearing the controller collection when pausing input, but only repopulating it when the connected device list changed (a device was connected or removed). Now we only clear the list on device list changed events or when the RawInputDataFetcher is deleted. Also fixed an error windows was throwing that indicated we were passing the wrong parameters to RegisterRawInputDevices when pausing input monitoring. BUG=413805 Committed: https://crrev.com/45793258429d8e260a6e025b2e4c8ff4a1bd53f5 Cr-Commit-Position: refs/heads/master@{#327603}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/browser/gamepad/raw_input_data_fetcher_win.cc View 3 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
bajones
PTAL
5 years, 7 months ago (2015-04-29 21:29:12 UTC) #2
scottmg
lgtm
5 years, 7 months ago (2015-04-29 21:45:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1113913003/1
5 years, 7 months ago (2015-04-29 21:50:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 22:50:50 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 22:52:42 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/45793258429d8e260a6e025b2e4c8ff4a1bd53f5
Cr-Commit-Position: refs/heads/master@{#327603}

Powered by Google App Engine
This is Rietveld 408576698