Issue 11139013: add browser_tests.gtest-drmemory_win32.txt for browser_tests with drmemory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11139013: add browser_tests.gtest-drmemory_win32.txt for browser_tests with drmemory (Closed)

Created:
8 years, 2 months ago by zhaoqin

Modified:
8 years, 2 months ago

Reviewers:
Lei Zhang, Timur Iskhodzhanov, Derek Bruening

CC:
chromium-reviews, glider+watch_chromium.org, pam+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

add browser_tests.gtest-drmemory_win32.txt for browser_tests with drmemory Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=162197

Patch Set 1 #

Total comments: 2

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -0 lines)			Patch
	A	tools/valgrind/gtest_exclude/browser_tests.gtest-drmemory_win32.txt	View		1 chunk	+16 lines, -0 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Derek Bruening

LGTM though I would recommend filing an issue https://codereview.chromium.org/11139013/diff/1/tools/valgrind/gtest_exclude/browser_tests.gtest-drmemory_win32.txt File tools/valgrind/gtest_exclude/browser_tests.gtest-drmemory_win32.txt (right): https://codereview.chromium.org/11139013/diff/1/tools/valgrind/gtest_exclude/browser_tests.gtest-drmemory_win32.txt#newcode1 tools/valgrind/gtest_exclude/browser_tests.gtest-drmemory_win32.txt:1: # ...

8 years, 2 months ago (2012-10-16 16:08:22 UTC) #1

Lei Zhang

It would certainly be nice to file a bug, though I didn't for my long ...

8 years, 2 months ago (2012-10-16 18:46:39 UTC) #2

zhaoqin

8 years, 2 months ago (2012-10-17 03:43:10 UTC) #3

On 2012/10/16 18:46:39, Lei Zhang wrote:
> It would certainly be nice to file a bug, though I didn't for my long list of
> failures. Some of these tests look familiar. They may simply be too slow?

I have filed the Dr.Memory issue tracker
http://code.google.com/p/drmemory/issues/detail?id=1052.
The Dr.Memory pattern mode is expected to be much faster than Memcheck, so have
to investigate why they timedout.

Expand Messages | Collapse Messages