Intrinsify natural word size typed array getters on IA32 and X64

runtime/vm/intrinsifier_x64.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_X64.
 #if defined(TARGET_ARCH_X64)
 
 #include "vm/intrinsifier.h"
 
 #include "vm/assembler.h"
@@ skipping 514 matching lines @@
                             R12,
                             TIMES_2,
                             Uint32Array::data_offset()));
   __ SmiTag(RAX);
   __ ret();
   __ Bind(&fall_through);
   return false;
 }
 
 
+bool Intrinsifier::Int64Array_getIndexed(Assembler* assembler) {
+  Label fall_through;
+  TestByteArrayIndex(assembler, &fall_through);
+  __ movq(RAX, FieldAddress(RAX,
+                            R12,
+                            TIMES_4,
+                            Int64Array::data_offset()));
+  // Copy RAX into R12.
+  // We destroy R12 while testing if RAX can fit inside a Smi.
+  __ movq(R12, RAX);
+  // Verify that the signed value in RAX can fit inside a Smi.
+  __ shlq(R12, Immediate(0x1));
+  // Jump to fall_through if it can not.
+  __ j(OVERFLOW, &fall_through, Assembler::kNearJump);
+  __ SmiTag(RAX);
+  __ ret();
+  __ Bind(&fall_through);
+  return false;
+}
+
+
+bool Intrinsifier::Uint64Array_getIndexed(Assembler* assembler) {
+  Label fall_through;
+  TestByteArrayIndex(assembler, &fall_through);
+  __ movq(RAX, FieldAddress(RAX,
+                            R12,
+                            TIMES_4,
+                            Uint64Array::data_offset()));
+  // Copy RAX into R12.
+  // We destroy R12 while testing if RAX can fit inside a Smi.
+  __ movq(R12, RAX);
+  // Verify that the unsigned value in RAX can be stored in a Smi.
+  __ shrq(R12, Immediate(62));

[cshapiro, 2012/10/12 22:33:52]

Please use the named constant kSmiBits instead of the number 62.

+  __ j(NOT_ZERO, &fall_through, Assembler::kNearJump);  // Won't fit Smi.
+  __ SmiTag(RAX);
+  __ ret();
+  __ Bind(&fall_through);
+  return false;
+}
+
+
 bool Intrinsifier::Float32Array_getIndexed(Assembler* assembler) {
   Label fall_through;
   TestByteArrayIndex(assembler, &fall_through);
   // After TestByteArrayIndex:
   // * RAX has the base address of the byte array.
   // * R12 has the index into the array.
   // R12 contains the SMI index which is shifted left by 1.
   // This shift means we only multiply the index by 2 not 4 (sizeof float).
   // Load single precision float into XMM7.
   __ movss(XMM7, FieldAddress(RAX, R12, TIMES_2,
@@ skipping 955 matching lines @@
   __ LoadObject(RAX, bool_true);
   __ ret();
   return true;
 }
 
 #undef __
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_X64