Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1113813002: [DevTools] Rename View to Widget. (Closed)

Created:
5 years, 7 months ago by dgozman
Modified:
5 years, 7 months ago
Reviewers:
pfeldman
CC:
blink-reviews, je_julie(Not used), shans, apavlov+blink_chromium.org, rjwright, aandrey+blink_chromium.org, caseq+blink_chromium.org, Steve Block, aboxhall, pfeldman+blink_chromium.org, yurys+blink_chromium.org, dstockwell, Timothy Loh, devtools-reviews_chromium.org, Eric Willigers, loislo+blink_chromium.org, blink-reviews-style_chromium.org, lushnikov+blink_chromium.org, dmazzoni, darktears, blink-reviews-animation_chromium.org, Mike Lawther (Google), nektarios, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[DevTools] Rename View to Widget. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194734

Patch Set 1 #

Patch Set 2 : tests #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1403 lines, -3696 lines) Patch
M LayoutTests/inspector/minimum-size.html View 1 1 chunk +85 lines, -85 lines 0 comments Download
M LayoutTests/inspector/minimum-size-expected.txt View 1 1 chunk +90 lines, -90 lines 0 comments Download
D LayoutTests/inspector/split-view.html View 1 1 chunk +0 lines, -128 lines 0 comments Download
D LayoutTests/inspector/split-view-expected.txt View 1 1 chunk +0 lines, -195 lines 0 comments Download
A LayoutTests/inspector/split-widget.html View 1 1 chunk +128 lines, -0 lines 0 comments Download
A + LayoutTests/inspector/split-widget-expected.txt View 1 9 chunks +21 lines, -21 lines 0 comments Download
D LayoutTests/inspector/view-events.html View 1 1 chunk +0 lines, -357 lines 0 comments Download
D LayoutTests/inspector/view-events-expected.txt View 1 1 chunk +0 lines, -240 lines 0 comments Download
A LayoutTests/inspector/widget-events.html View 1 1 chunk +357 lines, -0 lines 0 comments Download
A + LayoutTests/inspector/widget-events-expected.txt View 1 4 chunks +24 lines, -24 lines 0 comments Download
M Source/devtools/devtools.gypi View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/devtools/front_end/accessibility/AccessibilitySidebarView.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/audits/AuditsPanel.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/components/CustomPreviewSection.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/components/DOMPresentationUtils.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/components/Drawer.js View 7 chunks +13 lines, -13 lines 0 comments Download
M Source/devtools/front_end/components/InspectorView.js View 3 chunks +8 lines, -8 lines 0 comments Download
M Source/devtools/front_end/components/ObjectPopoverHelper.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/components/ShortcutsScreen.js View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/devtools/front_end/components_lazy/FilmStripView.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/console/ConsoleView.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/console/ConsoleViewMessage.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/elements/ElementsPanel.js View 5 chunks +16 lines, -16 lines 0 comments Download
M Source/devtools/front_end/elements/ElementsSidebarPane.js View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/devtools/front_end/elements/ElementsSidebarView.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/elements/ElementsTreeOutline.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/elements/StylesPopoverHelper.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/elements/animationTimeline.css View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/elements/elementsPanel.css View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/emulation/InspectedPagePlaceholder.js View 1 2 3 chunks +10 lines, -10 lines 0 comments Download
M Source/devtools/front_end/emulation/MediaQueryInspector.js View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/emulation/ResponsiveDesignView.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/extensions/ExtensionPanel.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/extensions/ExtensionView.js View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/inspectorCommon.css View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/layers/LayerPaintProfilerView.js View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/devtools/front_end/layers/LayersPanel.js View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/devtools/front_end/main/AdvancedApp.js View 4 chunks +14 lines, -14 lines 0 comments Download
M Source/devtools/front_end/network/NetworkItemView.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/network/NetworkPanel.js View 5 chunks +14 lines, -14 lines 0 comments Download
M Source/devtools/front_end/network/RequestCookiesView.js View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/devtools/front_end/network/RequestPreviewView.js View 4 chunks +12 lines, -12 lines 0 comments Download
M Source/devtools/front_end/network/RequestResponseView.js View 1 chunk +9 lines, -9 lines 0 comments Download
M Source/devtools/front_end/network/RequestView.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/network/ResourceWebSocketFrameView.js View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/devtools/front_end/network/XMLView.js View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/profiler/CPUProfileView.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/profiler/HeapSnapshotView.js View 13 chunks +56 lines, -56 lines 0 comments Download
M Source/devtools/front_end/profiler/ProfilesPanel.js View 6 chunks +8 lines, -8 lines 0 comments Download
M Source/devtools/front_end/resources/ApplicationCacheItemsView.js View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/devtools/front_end/resources/CookieItemsView.js View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/devtools/front_end/resources/DOMStorageItemsView.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/resources/DatabaseQueryView.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/resources/DatabaseTableView.js View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/devtools/front_end/resources/FileContentView.js View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/resources/FileSystemView.js View 6 chunks +7 lines, -7 lines 0 comments Download
M Source/devtools/front_end/resources/ResourcesPanel.js View 9 chunks +13 lines, -13 lines 0 comments Download
M Source/devtools/front_end/screencast/ScreencastApp.js View 3 chunks +10 lines, -10 lines 0 comments Download
M Source/devtools/front_end/source_frame/SourceFrame.js View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/sources/AdvancedSearchView.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/sources/FilteredItemSelectionDialog.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/sources/SourcesNavigator.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/sources/SourcesPanel.js View 9 chunks +23 lines, -23 lines 0 comments Download
M Source/devtools/front_end/sources/SourcesView.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/sources/StyleSheetOutlineDialog.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/sources/TabbedEditorContainer.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/sources/sourcesPanel.css View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/timeline/CountersGraph.js View 7 chunks +13 lines, -13 lines 0 comments Download
M Source/devtools/front_end/timeline/LayerDetailsView.js View 4 chunks +7 lines, -7 lines 0 comments Download
M Source/devtools/front_end/timeline/Layers3DView.js View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineFlameChart.js View 4 chunks +7 lines, -7 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineLayersView.js View 3 chunks +9 lines, -9 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelinePaintProfilerView.js View 3 chunks +12 lines, -12 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelinePanel.js View 7 chunks +16 lines, -16 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineView.js View 6 chunks +11 lines, -11 lines 0 comments Download
M Source/devtools/front_end/ui/ColorSwatch.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/ui/Dialog.js View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/ui/DropTarget.js View 1 chunk +1 line, -1 line 0 comments Download
D Source/devtools/front_end/ui/EmptyView.js View 1 chunk +0 lines, -59 lines 0 comments Download
A + Source/devtools/front_end/ui/EmptyWidget.js View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/ui/Infobar.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/ui/Panel.js View 3 chunks +13 lines, -13 lines 0 comments Download
M Source/devtools/front_end/ui/Popover.js View 5 chunks +6 lines, -6 lines 0 comments Download
M Source/devtools/front_end/ui/ProgressIndicator.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/ui/SearchableView.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/ui/Section.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/ui/SidebarPane.js View 4 chunks +6 lines, -6 lines 0 comments Download
M Source/devtools/front_end/ui/SoftContextMenu.js View 1 chunk +1 line, -1 line 0 comments Download
D Source/devtools/front_end/ui/SplitView.js View 1 chunk +0 lines, -899 lines 0 comments Download
A + Source/devtools/front_end/ui/SplitWidget.js View 26 chunks +99 lines, -99 lines 0 comments Download
M Source/devtools/front_end/ui/StackView.js View 1 chunk +15 lines, -15 lines 0 comments Download
M Source/devtools/front_end/ui/SuggestBox.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/ui/TabbedPane.js View 13 chunks +19 lines, -19 lines 0 comments Download
M Source/devtools/front_end/ui/TextPrompt.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/ui/Toolbar.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/ui/UIUtils.js View 6 chunks +6 lines, -6 lines 0 comments Download
D Source/devtools/front_end/ui/View.js View 1 chunk +0 lines, -687 lines 0 comments Download
A + Source/devtools/front_end/ui/Widget.js View 22 chunks +78 lines, -78 lines 0 comments Download
D Source/devtools/front_end/ui/emptyView.css View 1 chunk +0 lines, -15 lines 0 comments Download
A + Source/devtools/front_end/ui/emptyWidget.css View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/devtools/front_end/ui/module.json View 5 chunks +5 lines, -5 lines 0 comments Download
D Source/devtools/front_end/ui/splitView.css View 1 chunk +0 lines, -198 lines 0 comments Download
A + Source/devtools/front_end/ui/splitWidget.css View 4 chunks +36 lines, -36 lines 0 comments Download
M Source/devtools/front_end/ui/treeoutline.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/ui_lazy/DataGrid.js View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/ui_lazy/OverviewGrid.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/ui_lazy/PieChart.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/ui_lazy/TimelineGrid.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
dgozman
Take a look please.
5 years, 7 months ago (2015-04-29 14:00:09 UTC) #2
pfeldman
lgtm
5 years, 7 months ago (2015-04-30 09:34:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1113813002/40001
5 years, 7 months ago (2015-04-30 10:05:51 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-04-30 12:24:58 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194734

Powered by Google App Engine
This is Rietveld 408576698