Issue 11138029: cc: Remove wtf includes from layer_impl.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11138029: cc: Remove wtf includes from layer_impl.h (Closed)

Created:
8 years, 2 months ago by enne (OOO)

Modified:
8 years, 2 months ago

Reviewers:
jamesr

CC:
chromium-reviews, cc-bugs_chromium.org, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

cc: Remove wtf includes from layer_impl.h R=jamesr@chromium.org BUG=154451 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162060

Patch Set 2 : Fix android build #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -17 lines)			Patch
M	cc/layer_impl.h	View		4 chunks	+3 lines, -4 lines	0 comments	Download
M	cc/layer_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	cc/scrollbar_animation_controller.h	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	cc/scrollbar_animation_controller.cc	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
M	cc/scrollbar_animation_controller_linear_fade.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	cc/scrollbar_animation_controller_linear_fade.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	cc/scrollbar_animation_controller_linear_fade_unittest.cc	View		2 chunks	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jamesr

Think this might not quite compile on android, but otherwise lgtm https://codereview.chromium.org/11138029/diff/1/cc/scrollbar_animation_controller.cc File cc/scrollbar_animation_controller.cc (right): ...

8 years, 2 months ago (2012-10-16 00:23:50 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/11138029/4002

8 years, 2 months ago (2012-10-16 00:40:29 UTC) #3

Change committed as 162060

Expand Messages | Collapse Messages

Issue 11138029: cc: Remove wtf includes from layer_impl.h (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fix android build #

Messages