Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Unified Diff: lib/html/scripts/systemnative.py

Issue 11138028: Change return type to w3c standard of void for AudioBufferCallback. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« lib/html/scripts/systemhtml.py ('K') | « lib/html/scripts/systemhtml.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/html/scripts/systemnative.py
===================================================================
--- lib/html/scripts/systemnative.py (revision 13752)
+++ lib/html/scripts/systemnative.py (working copy)
@@ -52,7 +52,7 @@
cpp_header_handlers_emitter.Emit(
'\n'
- ' virtual bool handleEvent($PARAMETERS);\n',
+ ' virtual void handleEvent($PARAMETERS);\n',
Anton Muhin 2012/10/18 09:59:16 that's wrong: handleEvent in WebKit should return
PARAMETERS=', '.join(parameters))
if 'Custom' in operation.ext_attrs:
@@ -64,7 +64,7 @@
arguments_declaration = 'Dart_Handle* arguments = 0'
cpp_impl_handlers_emitter.Emit(
'\n'
- 'bool $CLASS_NAME::handleEvent($PARAMETERS)\n'
+ 'void $CLASS_NAME::handleEvent($PARAMETERS)\n'
Anton Muhin 2012/10/18 09:59:16 ditto
'{\n'
' if (!m_callback.isolate()->isAlive())\n'
' return false;\n'
« lib/html/scripts/systemhtml.py ('K') | « lib/html/scripts/systemhtml.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698