ui/surface/transport_dib_linux.cc - Issue 11138024: Simplify platform_canvas.h by recognizing that PlatformCanvas does not actually extend

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/surface/transport_dib_linux.cc

Issue 11138024: Simplify platform_canvas.h by recognizing that PlatformCanvas does not actually extend (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/surface/transport_dib_linux.cc

===================================================================

--- ui/surface/transport_dib_linux.cc (revision 167659)

+++ ui/surface/transport_dib_linux.cc (working copy)

@@ -94,10 +94,9 @@

skia::PlatformCanvas* TransportDIB::GetPlatformCanvas(int w, int h) {

if (address_ == kInvalidAddress && !Map())

return NULL;

- scoped_ptr<skia::PlatformCanvas> canvas(new skia::PlatformCanvas);

- if (!canvas->initialize(w, h, true, reinterpret_cast<uint8_t*>(memory())))

- return NULL;

- return canvas.release();

+ return skia::CreatePlatformCanvas(w, h, true,

+ reinterpret_cast<uint8_t*>(memory()),

+ skia::RETURN_NULL_ON_FAILURE);

}

bool TransportDIB::Map() {

« no previous file with comments | « ui/surface/transport_dib_android.cc ('k') | ui/surface/transport_dib_mac.cc » ('j') | no next file with comments »