Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9183)

Unified Diff: chrome/renderer/automation/automation_renderer_helper.cc

Issue 11138024: Simplify platform_canvas.h by recognizing that PlatformCanvas does not actually extend (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/automation/automation_renderer_helper.cc
===================================================================
--- chrome/renderer/automation/automation_renderer_helper.cc (revision 165342)
+++ chrome/renderer/automation/automation_renderer_helper.cc (working copy)
@@ -67,9 +67,10 @@
view->layout();
frame->setScrollOffset(WebSize(0, 0));
- skia::PlatformCanvas canvas(
- new_size.width, new_size.height, true /* is_opaque */);
- view->paint(webkit_glue::ToWebCanvas(&canvas),
+ SkCanvas* canvas = skia::CreatePlatformCanvas(new_size.width, new_size.height,
sky 2012/11/01 17:41:39 Is it possible to return a value like we did befor
reed1 2012/11/01 21:07:21 Makes sense. I'll see what I can come up with.
reed1 2012/11/02 15:49:39 ScopedPlatformCanvas Done.
+ true /* is_opaque */);
+ SkAutoUnref au(canvas);
+ view->paint(webkit_glue::ToWebCanvas(canvas),
gfx::Rect(0, 0, new_size.width, new_size.height));
frame->setCanHaveScrollbars(true);
@@ -80,7 +81,7 @@
frame->setScrollOffset(WebSize(old_scroll.width - min_scroll.width,
old_scroll.height - min_scroll.height));
- const SkBitmap& bmp = skia::GetTopDevice(canvas)->accessBitmap(false);
+ const SkBitmap& bmp = skia::GetTopDevice(*canvas)->accessBitmap(false);
SkAutoLockPixels lock_pixels(bmp);
// EncodeBGRA uses FORMAT_SkBitmap, which doesn't work on windows for some
// cases dealing with transparency. See crbug.com/96317. Use FORMAT_BGRA.
« no previous file with comments | « no previous file | chrome/renderer/chrome_render_view_observer.cc » ('j') | skia/ext/bitmap_platform_device_win.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698