Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1060)

Side by Side Diff: ppapi/thunk/ppb_image_data_api.h

Issue 11138024: Simplify platform_canvas.h by recognizing that PlatformCanvas does not actually extend (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef PPAPI_THUNK_PPB_IMAGE_DATA_API_H_ 5 #ifndef PPAPI_THUNK_PPB_IMAGE_DATA_API_H_
6 #define PPAPI_THUNK_PPB_IMAGE_DATA_API_H_ 6 #define PPAPI_THUNK_PPB_IMAGE_DATA_API_H_
7 7
8 #include "ppapi/c/pp_bool.h" 8 #include "ppapi/c/pp_bool.h"
9 #include "ppapi/c/ppb_image_data.h" 9 #include "ppapi/c/ppb_image_data.h"
10 10
11 namespace skia {
12 class PlatformCanvas;
13 }
14
15 class SkCanvas; 11 class SkCanvas;
16 12
17 namespace ppapi { 13 namespace ppapi {
18 namespace thunk { 14 namespace thunk {
19 15
20 class PPB_ImageData_API { 16 class PPB_ImageData_API {
21 public: 17 public:
22 virtual ~PPB_ImageData_API() {} 18 virtual ~PPB_ImageData_API() {}
23 19
24 virtual PP_Bool Describe(PP_ImageDataDesc* desc) = 0; 20 virtual PP_Bool Describe(PP_ImageDataDesc* desc) = 0;
25 virtual void* Map() = 0; 21 virtual void* Map() = 0;
26 virtual void Unmap() = 0; 22 virtual void Unmap() = 0;
27 23
28 // Trusted inteface. 24 // Trusted inteface.
29 virtual int32_t GetSharedMemory(int* handle, uint32_t* byte_count) = 0; 25 virtual int32_t GetSharedMemory(int* handle, uint32_t* byte_count) = 0;
30 26
31 // Get the platform-specific canvas that backs this ImageData, if there is 27 // Get the platform-specific canvas that backs this ImageData, if there is
32 // one. 28 // one.
33 // The canvas will be NULL: 29 // The canvas will be NULL:
34 // * If the image is not mapped. 30 // * If the image is not mapped.
35 // * Within untrusted code (which does not have skia). 31 // * Within untrusted code (which does not have skia).
36 // * If the ImageData is not backed by a platform-specific image buffer. 32 // * If the ImageData is not backed by a platform-specific image buffer.
37 // This will be the case for ImageDatas created for use in NaCl. 33 // This will be the case for ImageDatas created for use in NaCl.
38 // For this last reason, you should prefer GetCanvas any time you don't need 34 // For this last reason, you should prefer GetCanvas any time you don't need
39 // a platform-specific canvas (e.g., for use with platform-specific APIs). 35 // a platform-specific canvas (e.g., for use with platform-specific APIs).
40 // Anything that relies on having a PlatformCanvas will not work for ImageDat 36 // Anything that relies on having a PlatformCanvas will not work for ImageDat
41 // objects created from NaCl. 37 // objects created from NaCl.
42 virtual skia::PlatformCanvas* GetPlatformCanvas() = 0; 38 virtual SkCanvas* GetPlatformCanvas() = 0;
43 39
44 // Get the canvas that backs this ImageData, if there is one. 40 // Get the canvas that backs this ImageData, if there is one.
45 // The canvas will be NULL: 41 // The canvas will be NULL:
46 // * If the image is not mapped. 42 // * If the image is not mapped.
47 // * Within untrusted code (which does not have skia). 43 // * Within untrusted code (which does not have skia).
48 virtual SkCanvas* GetCanvas() = 0; 44 virtual SkCanvas* GetCanvas() = 0;
49 }; 45 };
50 46
51 } // namespace thunk 47 } // namespace thunk
52 } // namespace ppapi 48 } // namespace ppapi
53 49
54 #endif // PPAPI_THUNK_PPB_IMAGE_DATA_API_H_ 50 #endif // PPAPI_THUNK_PPB_IMAGE_DATA_API_H_
OLDNEW
« no previous file with comments | « ppapi/shared_impl/private/ppb_browser_font_trusted_shared.cc ('k') | skia/ext/bitmap_platform_device_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698