Issue 11138019: Merge 157675 - Content Settings bubble does not display RTL text. This is the case because we

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11138019: Merge 157675 - Content Settings bubble does not display RTL text. This is the case because we (Closed)

Created:
8 years, 2 months ago by Greg Billock

Modified:
8 years, 2 months ago

Reviewers:
varunjain

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/branches/1271/src/

Visibility:
Public.

Merge 157675 - Content Settings bubble does not display RTL text. This is the case because we manually draw the string in the bubble without taking RTL into account. We fix this by using a views::Label instead that takes care of RTL when drawing text. BUG=150694 Review URL: https://chromiumcodereview.appspot.com/10949024 TBR=varunjain@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=161900

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -46 lines)			Patch
	M	chrome/browser/ui/views/location_bar/location_bar_decoration_view.h	View		6 chunks	+12 lines, -5 lines	0 comments	Download
	M	chrome/browser/ui/views/location_bar/location_bar_decoration_view.cc	View		6 chunks	+38 lines, -41 lines	0 comments	Download

Total messages: 1 (0 generated)