Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1113773002: Replacing v8::Handle<T> with v8::Local<T> (Closed)

Created:
5 years, 7 months ago by ashish1.a
Modified:
5 years, 7 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Replacing v8::Handle<T> with v8::Local<T> v8::Handle<T> is just an alias of v8::Local<T> so, replacing v8::Handle with v8::Local in Source/core/* BUG=424445 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194701

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M Source/core/dom/Document.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/Document.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/Node.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/Node.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/streams/ReadableStream.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
ashish1.a
Please review. Regards, Ashish
5 years, 7 months ago (2015-04-29 11:45:15 UTC) #2
haraken
LGTM
5 years, 7 months ago (2015-04-29 11:50:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1113773002/1
5 years, 7 months ago (2015-04-30 04:04:28 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-04-30 05:38:50 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194701

Powered by Google App Engine
This is Rietveld 408576698