Issue 11137016: Prepare push to trunk. Now working on version 3.14.5.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11137016: Prepare push to trunk. Now working on version 3.14.5. (Closed)

Created:
8 years, 2 months ago by Sven Panne

Modified:
8 years, 2 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Prepare push to trunk. Now working on version 3.14.5. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=12728

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -1 line)			Patch
	M	ChangeLog	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download
	M	src/version.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

8 years, 2 months ago (2012-10-15 11:46:12 UTC) #2

LGTM with comments.

https://codereview.chromium.org/11137016/diff/1/ChangeLog
File ChangeLog (right):

https://codereview.chromium.org/11137016/diff/1/ChangeLog#newcode6
ChangeLog:6: Ensure code flushing is disabled in incremental marking. (issue
1609)
nit: past tense please.

On a higher level, I don't think this entry is interesting. Let's just drop it.

https://codereview.chromium.org/11137016/diff/1/ChangeLog#newcode8
ChangeLog:8: Move code flushing support into shared visitor. (issue 1609)
Same here. Past tense if you insist on keeping it, but internal
refactorings/cleanup don't really deserve a ChangeLog entry.

https://codereview.chromium.org/11137016/diff/1/ChangeLog#newcode10
ChangeLog:10: Enable --verify-heap in release mode (issue 2120)
nit: past tense please

Expand Messages | Collapse Messages