Issue 11137015: Reland r161839 - [content shell] don't use webkit_support functions to manipulate URLs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11137015: Reland r161839 - [content shell] don't use webkit_support functions to manipulate URLs (Closed)

Created:
8 years, 2 months ago by jochen (gone - plz use gerrit)

Modified:
8 years, 2 months ago

Reviewers:
marja

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Reland r161839 - [content shell] don't use webkit_support functions to manipulate URLs In single-process mode, WebKit isn't yet initialized before we start a renderer, so we can't pass around WebURLs BUG=111316 TEST=content_shell --dump-render-tree --single-process doesn't crash Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=161879

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -3 lines)			Patch
	M	content/shell/shell_browser_main.cc	View		2 chunks	+17 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/11137015/1

8 years, 2 months ago (2012-10-15 13:09:14 UTC) #3

commit-bot: I haz the power

8 years, 2 months ago (2012-10-15 13:09:17 UTC) #4

Presubmit check for 11137015-1 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit Warnings **
New code should not use wstrings.  If you are calling a cross-platform API that
accepts a wstring, fix the API.
    content/shell/shell_browser_main.cc:50

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

Expand Messages | Collapse Messages