Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(806)

Side by Side Diff: src/mark-compact.cc

Issue 11137014: Ensure code flushing is disabled in incremental marking. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1985 matching lines...) Expand 10 before | Expand all | Expand 10 after
1996 MarkCompactWeakObjectRetainer mark_compact_object_retainer; 1996 MarkCompactWeakObjectRetainer mark_compact_object_retainer;
1997 heap()->ProcessWeakReferences(&mark_compact_object_retainer); 1997 heap()->ProcessWeakReferences(&mark_compact_object_retainer);
1998 1998
1999 // Remove object groups after marking phase. 1999 // Remove object groups after marking phase.
2000 heap()->isolate()->global_handles()->RemoveObjectGroups(); 2000 heap()->isolate()->global_handles()->RemoveObjectGroups();
2001 heap()->isolate()->global_handles()->RemoveImplicitRefGroups(); 2001 heap()->isolate()->global_handles()->RemoveImplicitRefGroups();
2002 2002
2003 // Flush code from collected candidates. 2003 // Flush code from collected candidates.
2004 if (is_code_flushing_enabled()) { 2004 if (is_code_flushing_enabled()) {
2005 code_flusher_->ProcessCandidates(); 2005 code_flusher_->ProcessCandidates();
2006 // TODO(1609) Currently incremental marker does not support code flushing,
2007 // we need to disable it before incremental marking steps for next cycle.
2008 EnableCodeFlushing(false);
2006 } 2009 }
2007 2010
2008 if (!FLAG_watch_ic_patching) { 2011 if (!FLAG_watch_ic_patching) {
2009 // Clean up dead objects from the runtime profiler. 2012 // Clean up dead objects from the runtime profiler.
2010 heap()->isolate()->runtime_profiler()->RemoveDeadSamples(); 2013 heap()->isolate()->runtime_profiler()->RemoveDeadSamples();
2011 } 2014 }
2012 2015
2013 if (FLAG_track_gc_object_stats) { 2016 if (FLAG_track_gc_object_stats) {
2014 heap()->CheckpointObjectStats(); 2017 heap()->CheckpointObjectStats();
2015 } 2018 }
(...skipping 1734 matching lines...) Expand 10 before | Expand all | Expand 10 after
3750 while (buffer != NULL) { 3753 while (buffer != NULL) {
3751 SlotsBuffer* next_buffer = buffer->next(); 3754 SlotsBuffer* next_buffer = buffer->next();
3752 DeallocateBuffer(buffer); 3755 DeallocateBuffer(buffer);
3753 buffer = next_buffer; 3756 buffer = next_buffer;
3754 } 3757 }
3755 *buffer_address = NULL; 3758 *buffer_address = NULL;
3756 } 3759 }
3757 3760
3758 3761
3759 } } // namespace v8::internal 3762 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698