Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 111363002: Add chromedriver_unittests to masters. (Closed)

Created:
7 years ago by kkania
Modified:
7 years ago
CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org, xusydoc+watch_chromium.org, kjellander+cc_chromium.org
Visibility:
Public.

Description

Add chromedriver_unittests to masters. This target is identical to chromedriver2_unittests and will eventually replace it, although we need to do this in phases so as not to break cq/lkgr. This target has been part of chromium_builder_tests for a month. BUG=298192 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=240492

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -84 lines) Patch
M masters/master.chromium.chromiumos/master_chromiumos_cfg.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M masters/master.chromium.fyi/master.cfg View 1 4 chunks +4 lines, -0 lines 0 comments Download
M masters/master.chromium.linux/master_gatekeeper_cfg.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M masters/master.chromium.linux/master_linux_cfg.py View 1 6 chunks +6 lines, -0 lines 0 comments Download
M masters/master.chromium.mac/master_gatekeeper_cfg.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M masters/master.chromium.mac/master_mac_cfg.py View 1 3 chunks +3 lines, -0 lines 0 comments Download
M masters/master.chromium.memory.fyi/master.cfg View 1 1 chunk +1 line, -0 lines 0 comments Download
M masters/master.chromium.memory/master_chromeos_cfg.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M masters/master.chromium.memory/master_linux_cfg.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M masters/master.chromium.memory/master_mac_cfg.py View 1 3 chunks +3 lines, -0 lines 0 comments Download
M masters/master.chromium.webkit/master_win_latest_cfg.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M masters/master.chromium.win/master_gatekeeper_cfg.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M masters/master.chromium.win/master_win_cfg.py View 1 4 chunks +4 lines, -0 lines 0 comments Download
M masters/master.tryserver.chromium/master.cfg View 1 5 chunks +5 lines, -0 lines 0 comments Download
M scripts/master/factory/chromium_factory.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/kill_processes.py View 1 chunk +1 line, -0 lines 0 comments Download
M tests/data/trymail_tests/buildrunner_tryserver.expected View 1 1 chunk +86 lines, -84 lines 0 comments Download
M tests/data/trymail_tests/buildrunner_tryserver.in View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
kkania
7 years ago (2013-12-10 06:13:18 UTC) #1
cmp
+agable, iannucci for a full review Ken, can you send the other reviews to them, ...
7 years ago (2013-12-10 17:53:53 UTC) #2
cmp
+agable for real
7 years ago (2013-12-10 17:54:13 UTC) #3
agable
LGTM, except for the buildrunner expectations, which either Robbie or Mike should look at.
7 years ago (2013-12-10 18:01:25 UTC) #4
kkania
alright, let me know if there's anything i can do to help with the buildrunner ...
7 years ago (2013-12-10 20:41:24 UTC) #5
ghost stip (do not use)
I think the buildrunner expectations are unrelated to actual buildrunner. lgtm, sorry for the lag ...
7 years ago (2013-12-13 00:01:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkania@chromium.org/111363002/20001
7 years ago (2013-12-13 00:05:38 UTC) #7
commit-bot: I haz the power
7 years ago (2013-12-13 00:06:40 UTC) #8
Message was sent while issue was closed.
Change committed as 240492

Powered by Google App Engine
This is Rietveld 408576698