Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1113603003: [iOS] Fix a typo in ios_strings_resources.grd (Closed)

Created:
5 years, 7 months ago by sdefresne
Modified:
5 years, 7 months ago
Reviewers:
droger
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[iOS] Fix a typo in ios_strings_resources.grd tools/grit/grit.py does not recognize "preprend" as a valid emit_type but instead understand "prepend" which avoid the inclusion of atlres.h in the generated file. BUG=475514 Committed: https://crrev.com/51689d131ef4401d3349684ab466e666469f2c7e Cr-Commit-Position: refs/heads/master@{#327323}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ios/chrome/app/strings/ios_strings_resources.grd View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
sdefresne
5 years, 7 months ago (2015-04-28 17:37:32 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1113603003/1
5 years, 7 months ago (2015-04-28 17:37:47 UTC) #3
droger
lgtm
5 years, 7 months ago (2015-04-28 17:37:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1113603003/1
5 years, 7 months ago (2015-04-28 17:38:36 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-28 18:06:32 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 18:07:24 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/51689d131ef4401d3349684ab466e666469f2c7e
Cr-Commit-Position: refs/heads/master@{#327323}

Powered by Google App Engine
This is Rietveld 408576698