Issue 1113603002: Decrement SkCanvas::fDeferredSaveCount in doSave()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1113603002: Decrement SkCanvas::fDeferredSaveCount in doSave() (Closed)

Created:
5 years, 7 months ago by f(malita)

Modified:
5 years, 7 months ago

Reviewers:
robertphillips, reed1

CC:
reviews_skia.org

Base URL:
https://chromium.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Decrement SkCanvas::fDeferredSaveCount in doSave() We're currently decrementing early in checkForDeferredSave(), but that means we break the getSaveCount() invariant during willSave() dispatch. Instead, we can defer to doSave(), until after willSave() is called. This allows overriders to call getSaveCount(). R=reed@google.com,robertphillips@google.com Committed: https://skia.googlesource.com/skia/+/a62d32d1e3112c7e5a26c27e5e967d124ef8dd81

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	src/core/SkCanvas.cpp	View		2 chunks	+3 lines, -1 line	0 comments	Download

Total messages: 5 (1 generated)

f(malita)

pinspect --dump-ops crashes in debug mode because it calls getSaveCount() from its willSave() override: ../../src/core/SkCanvas.cpp:820: ...

5 years, 7 months ago (2015-04-28 14:23:24 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1113603002/1

5 years, 7 months ago (2015-04-28 14:56:09 UTC) #4

commit-bot: I haz the power

5 years, 7 months ago (2015-04-28 15:09:00 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a62d32d1e3112c7e5a26c27e5e967d124ef8dd81