Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 1113593002: Allow extra library files to be snapshotted (Closed)

Created:
5 years, 7 months ago by domenic
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Allow extra library files to be snapshotted BUG= R=jochen@chromium.org, yangguo@chromium.org Committed: https://crrev.com/8a89a4a5ceeb58303cd9bc2d3e8d362742d59c96 Cr-Commit-Position: refs/heads/master@{#28110}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -18 lines) Patch
M tools/gyp/v8.gyp View 4 chunks +7 lines, -3 lines 0 comments Download
M tools/js2c.py View 3 chunks +23 lines, -15 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
domenic
5 years, 7 months ago (2015-04-28 14:16:15 UTC) #1
jochen (gone - plz use gerrit)
lgtm
5 years, 7 months ago (2015-04-28 14:17:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1113593002/1
5 years, 7 months ago (2015-04-28 14:21:49 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-28 14:56:02 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 14:56:19 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8a89a4a5ceeb58303cd9bc2d3e8d362742d59c96
Cr-Commit-Position: refs/heads/master@{#28110}

Powered by Google App Engine
This is Rietveld 408576698