SkPDF: Remove unused deprecated functions in SkPDFTypes

SkPDF: Remove unused deprecated functions in SkPDFTypes

depends on:
    http://crrev.com/1107923002
    http://crrev.com/1103163002
    http://crrev.com/1110533002
    http://crrev.com/1107913002
    http://crrev.com/1106163002

BUG=skia:3585
Committed: https://skia.googlesource.com/skia/+/002653e78c1eef4430abe457f6f91add24a69093

[hal.canary, 2015-04-28 13:58:36]

halcanary@google.com changed reviewers:
+ tomhudson@google.com

[hal.canary, 2015-04-28 13:58:37]

review this one last.

Thanks!

[tomhudson, 2015-05-04 18:31:55]

lgtm

https://codereview.chromium.org/1113583002/diff/1/src/pdf/SkPDFTypes.h
File src/pdf/SkPDFTypes.h (right):

https://codereview.chromium.org/1113583002/diff/1/src/pdf/SkPDFTypes.h#newcod...
src/pdf/SkPDFTypes.h:163: #if 0  // Enable if needed.
... because you're trying to deprecate? *why*?

https://codereview.chromium.org/1113583002/diff/1/src/pdf/SkPDFTypes.h#newcod...
src/pdf/SkPDFTypes.h:181: class SkPDFScalar {
Now that you've gotten rid of the idea of objects of this class or of
SkPDFString (yay!), is there a preexisting namespace that Append() and
FormatString() could belong to (perhaps with longer names)? Or are they
important enough that they justify these two distinct utilities?

[hal.canary, 2015-05-04 18:48:44]

https://codereview.chromium.org/1113583002/diff/1/src/pdf/SkPDFTypes.h
File src/pdf/SkPDFTypes.h (right):

https://codereview.chromium.org/1113583002/diff/1/src/pdf/SkPDFTypes.h#newcod...
src/pdf/SkPDFTypes.h:181: class SkPDFScalar {
On 2015/05/04 18:31:55, tomhudson wrote:
> Now that you've gotten rid of the idea of objects of this class or of
> SkPDFString (yay!), is there a preexisting namespace that Append() and
> FormatString() could belong to (perhaps with longer names)? Or are they
> important enough that they justify these two distinct utilities?

I'll move them to SkPDFUtils at a later date.

[hal.canary, 2015-05-05 17:58:29]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-05-05 17:58:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1113583002/1

[commit-bot: I haz the power, 2015-05-05 18:04:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-05 18:04:32]

Dry run: This issue passed the CQ dry run.

[hal.canary, 2015-05-05 18:28:30]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2015-05-05 18:28:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1113583002/1

[commit-bot: I haz the power, 2015-05-05 18:28:59]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/002653e78c1eef4430abe457f6f91add24a69093