content/browser/frame_host/render_widget_host_view_child_frame.cc - Issue 1113573002: Maintain minimal error response.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_widget_host_view_child_frame.cc

Issue 1113573002: Maintain minimal error response. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove READBACK_NOT_SUPPORTED Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/render_widget_host_view_child_frame.cc

diff --git a/content/browser/frame_host/render_widget_host_view_child_frame.cc b/content/browser/frame_host/render_widget_host_view_child_frame.cc

index ebbea17c2a927c70d7ad24f782b1946d61e31fdc..c25677c493f7fb98537e41abc91bd0fdecfc76f2 100644

--- a/content/browser/frame_host/render_widget_host_view_child_frame.cc

+++ b/content/browser/frame_host/render_widget_host_view_child_frame.cc

@@ -263,7 +263,7 @@ void RenderWidgetHostViewChildFrame::CopyFromCompositingSurface(

const gfx::Size& /* dst_size */,

ReadbackRequestCallback& callback,

const SkColorType color_type) {

no sievers 2015/05/06 23:08:03 Should we rename this to |preferred_color_type| th

sivag 2015/05/07 14:14:20 Done.

- callback.Run(SkBitmap(), READBACK_NOT_SUPPORTED);

+ callback.Run(SkBitmap(), READBACK_FAILED);

}

void RenderWidgetHostViewChildFrame::CopyFromCompositingSurfaceToVideoFrame(