Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1113553002: ChromeOS Gaia: Fixed slide-from-right transitions for rtl languages. (Closed)

Created:
5 years, 7 months ago by Roman Sorokin (ftl)
Modified:
5 years, 7 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ChromeOS Gaia: Fixed slide-from-right transitions for rtl languages. BUG=479091 Committed: https://crrev.com/0b4d74d6dbaf1f408917f801aa1abb8d39d7c4d0 Cr-Commit-Position: refs/heads/master@{#327488}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M chrome/browser/resources/chromeos/login/offline_gaia.html View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/login/offline_gaia.js View 4 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Roman Sorokin (ftl)
Nikita, please review
5 years, 7 months ago (2015-04-28 12:01:05 UTC) #2
Nikita (slow)
lgtm please ask on polymer-dev@googlegroups.com whether there's a better approach
5 years, 7 months ago (2015-04-28 14:24:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1113553002/1
5 years, 7 months ago (2015-04-29 13:47:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 14:19:37 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 14:20:45 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/0b4d74d6dbaf1f408917f801aa1abb8d39d7c4d0
Cr-Commit-Position: refs/heads/master@{#327488}

Powered by Google App Engine
This is Rietveld 408576698