Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 1113523002: Use Local<> instead of Handle<> (Closed)

Created:
5 years, 7 months ago by deepak.s
Modified:
5 years, 7 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, arv+blink, vivekg
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Use Local<> instead of Handle<> Replacing Handle<> with Local<> in core/v8/* BUG=424445 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194642

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -32 lines) Patch
M Source/bindings/core/v8/DOMWrapperMap.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/DOMWrapperWorld.h View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/bindings/core/v8/DictionaryHelperForCore.cpp View 13 chunks +15 lines, -15 lines 0 comments Download
M Source/bindings/core/v8/ExceptionState.h View 6 chunks +7 lines, -7 lines 0 comments Download
M Source/bindings/core/v8/ExceptionState.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/ExceptionStatePlaceholder.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/ExceptionStatePlaceholder.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
deepak.s
PTAL? Thanks!
5 years, 7 months ago (2015-04-29 03:30:23 UTC) #2
haraken
LGTM
5 years, 7 months ago (2015-04-29 03:40:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1113523002/1
5 years, 7 months ago (2015-04-29 03:43:52 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 03:47:20 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194642

Powered by Google App Engine
This is Rietveld 408576698