Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3690)

Unified Diff: cc/trees/single_thread_proxy.cc

Issue 1113493007: Allow cc::STP::SetNeedsAnimate to request another commit from a commit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/trees/single_thread_proxy.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/single_thread_proxy.cc
diff --git a/cc/trees/single_thread_proxy.cc b/cc/trees/single_thread_proxy.cc
index b9f6a4849131dfa14431b6f7a0b48dd4fe81fab9..0ae9440a2ab9c5adad40ce203c9e739009c62b9d 100644
--- a/cc/trees/single_thread_proxy.cc
+++ b/cc/trees/single_thread_proxy.cc
@@ -47,6 +47,7 @@ SingleThreadProxy::SingleThreadProxy(
next_frame_is_newly_committed_frame_(false),
inside_draw_(false),
defer_commits_(false),
+ animate_requested_(false),
commit_requested_(false),
inside_synchronous_composite_(false),
output_surface_creation_requested_(false),
@@ -178,7 +179,13 @@ void SingleThreadProxy::SetNeedsAnimate() {
TRACE_EVENT0("cc", "SingleThreadProxy::SetNeedsAnimate");
DCHECK(Proxy::IsMainThread());
client_->ScheduleAnimation();
- SetNeedsCommit();
+ if (animate_requested_) {
danakj 2015/04/28 21:47:49 nit: no {}
+ return;
+ }
+ animate_requested_ = true;
+ DebugScopedSetImplThread impl(this);
+ if (scheduler_on_impl_thread_)
+ scheduler_on_impl_thread_->SetNeedsCommit();
}
void SingleThreadProxy::SetNeedsUpdateLayers() {
@@ -335,10 +342,10 @@ void SingleThreadProxy::SetNeedsCommit() {
client_->ScheduleComposite();
if (commit_requested_)
return;
+ commit_requested_ = true;
DebugScopedSetImplThread impl(this);
if (scheduler_on_impl_thread_)
scheduler_on_impl_thread_->SetNeedsCommit();
- commit_requested_ = true;
}
void SingleThreadProxy::SetNeedsRedraw(const gfx::Rect& damage_rect) {
@@ -809,6 +816,7 @@ void SingleThreadProxy::SendBeginMainFrameNotExpectedSoon() {
void SingleThreadProxy::BeginMainFrame() {
commit_requested_ = false;
+ animate_requested_ = false;
if (defer_commits_) {
TRACE_EVENT_INSTANT0("cc", "EarlyOut_DeferCommit",
@@ -838,6 +846,8 @@ void SingleThreadProxy::BeginMainFrame() {
}
// Prevent new commits from being requested inside DoBeginMainFrame.
+ // Note: We do not want to prevent SetNeedsAnimate from requesting
+ // a commit here.
commit_requested_ = true;
const BeginFrameArgs& begin_frame_args =
« no previous file with comments | « cc/trees/single_thread_proxy.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698