Allow cc::STP::SetNeedsAnimate to request another commit from a commit

Allow cc::STP::SetNeedsAnimate to request another commit from a commit

This makes SingleThreadProxy behave like ThreadProxy.

BUG=481436
Committed: https://crrev.com/49e101d29ee1fa026ea609fb7bbd229a7e223d6a
Cr-Commit-Position: refs/heads/master@{#327396}

[brianderson, 2015-04-28 19:20:22]

All tests pass, so this will need a regression test.

[brianderson, 2015-04-28 19:33:57]

brianderson@chromium.org changed reviewers:
+ danakj@chromium.org

[brianderson, 2015-04-28 19:33:58]

Test already existed. Just needed to enable it for STP. The test fails before
this patch and passes with it.

[danakj, 2015-04-28 20:00:44]

https://codereview.chromium.org/1113493007/diff/20001/cc/trees/single_thread_...
File cc/trees/single_thread_proxy.cc (right):

https://codereview.chromium.org/1113493007/diff/20001/cc/trees/single_thread_...
cc/trees/single_thread_proxy.cc:182: SetNeedsCommitOnImplThread();
This would ScheduleComposite twice, and we should early out of SNA() if SNA()
was already called.

[danakj, 2015-04-28 20:03:11]

I was going to do basically the same thing as this :)
https://codereview.chromium.org/1109203004

Can you add a animate_requested_ like I did over there basically?

https://codereview.chromium.org/1113493007/diff/20001/cc/trees/single_thread_...
File cc/trees/single_thread_proxy.cc (right):

https://codereview.chromium.org/1113493007/diff/20001/cc/trees/single_thread_...
cc/trees/single_thread_proxy.cc:840: // Prevent new commits from being requested
inside DoBeginMainFrame.
Can you add a comment here about this shouldn't affect SetNeedsAnimate like we
have in ThreadProxy too?

[brianderson, 2015-04-28 20:33:55]

Looks a lot more like Dana's patch now. Ptal.

Duped call to ScheduleComposite is gone now.

Went ahead and added a the animate_requested flag. I was under the impression
that was to avoid too many PostTasks for ThreadProxy, but I guess it'll also be
good to avoid calling ProcessScheduledActions too often.

[danakj, 2015-04-28 21:47:50]

LGTM

https://codereview.chromium.org/1113493007/diff/40001/cc/trees/single_thread_...
File cc/trees/single_thread_proxy.cc (right):

https://codereview.chromium.org/1113493007/diff/40001/cc/trees/single_thread_...
cc/trees/single_thread_proxy.cc:182: if (animate_requested_) {
nit: no {}

[brianderson, 2015-04-28 22:01:14]

The CQ bit was checked by brianderson@chromium.org

[brianderson, 2015-04-28 22:01:15]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/1113493007/#ps60001
(title: "remove {}'s")

[commit-bot: I haz the power, 2015-04-28 22:02:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1113493007/60001

[commit-bot: I haz the power, 2015-04-29 00:05:43]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-04-29 00:07:36]

Patchset 4 (id:??) landed as
https://crrev.com/49e101d29ee1fa026ea609fb7bbd229a7e223d6a
Cr-Commit-Position: refs/heads/master@{#327396}