Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(877)

Issue 1113493005: [remoting] Replace MessageLoopProxy usage with ThreadTaskRunnerHandle (Closed)

Created:
5 years, 7 months ago by anujsharma
Modified:
5 years, 7 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, dcheng, chromoting-reviews_chromium.org, Pranay
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace MessageLoopProxy usage with ThreadTaskRunnerHandle in remoting module. MessageLoopProxy is deprecated. This basically does a search and replace: MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get(). BUG=391045 Committed: https://crrev.com/bb802938545822678c2ef22719f80f143f3c093e Cr-Commit-Position: refs/heads/master@{#328413}

Patch Set 1 #

Total comments: 6

Patch Set 2 : Fized comments #

Patch Set 3 : Fixed build break #

Patch Set 4 : Fixed nits #

Patch Set 5 : Chnaged to SingleThreadTaskRunner #

Patch Set 6 : Final touch #

Patch Set 7 : Ready for review with finetune changes #

Total comments: 4

Patch Set 8 : Fixed nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -17 lines) Patch
M remoting/client/client_status_logger_unittest.cc View 1 2 3 4 5 6 7 3 chunks +0 lines, -3 lines 0 comments Download
M remoting/host/client_session.cc View 1 2 3 4 5 2 chunks +3 lines, -2 lines 0 comments Download
M remoting/host/heartbeat_sender.h View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M remoting/host/host_status_logger_unittest.cc View 1 2 3 4 5 6 7 3 chunks +0 lines, -3 lines 0 comments Download
M remoting/host/policy_watcher_unittest.cc View 1 2 3 4 5 6 3 chunks +4 lines, -4 lines 0 comments Download
M remoting/protocol/clipboard_thread_proxy.h View 1 2 3 4 5 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (2 generated)
anujsharma
PTAL
5 years, 7 months ago (2015-04-28 13:46:06 UTC) #2
Sergey Ulanov
Thank you for the cleanup! https://codereview.chromium.org/1113493005/diff/1/remoting/host/heartbeat_sender.h File remoting/host/heartbeat_sender.h (right): https://codereview.chromium.org/1113493005/diff/1/remoting/host/heartbeat_sender.h#newcode22 remoting/host/heartbeat_sender.h:22: class SingleThreadTaskRunner; SingleThreadTaskRunner is ...
5 years, 7 months ago (2015-04-28 17:03:23 UTC) #3
anujsharma
Thanks Sergey for your comments!! Sorry for the delay in response. I have made the ...
5 years, 7 months ago (2015-05-04 12:38:21 UTC) #4
Sergey Ulanov
couple more nits. https://codereview.chromium.org/1113493005/diff/120001/remoting/client/client_status_logger_unittest.cc File remoting/client/client_status_logger_unittest.cc (right): https://codereview.chromium.org/1113493005/diff/120001/remoting/client/client_status_logger_unittest.cc#newcode81 remoting/client/client_status_logger_unittest.cc:81: scoped_refptr<base::SingleThreadTaskRunner> message_loop_proxy_; This isn't used anywhere ...
5 years, 7 months ago (2015-05-04 20:49:58 UTC) #5
anujsharma
Thanks sergey for your comments!! Fixed the comments!! Could you please take a look. Thanks!! ...
5 years, 7 months ago (2015-05-05 10:59:05 UTC) #6
Sergey Ulanov
LGTM. Thank you for the cleanup!
5 years, 7 months ago (2015-05-05 18:50:31 UTC) #7
anujsharma
On 2015/05/05 18:50:31, Sergey Ulanov wrote: > LGTM. Thank you for the cleanup! Thanks sergey ...
5 years, 7 months ago (2015-05-05 19:06:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1113493005/140001
5 years, 7 months ago (2015-05-05 19:08:22 UTC) #10
commit-bot: I haz the power
Committed patchset #8 (id:140001)
5 years, 7 months ago (2015-05-05 21:57:41 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-05-05 21:58:34 UTC) #12
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/bb802938545822678c2ef22719f80f143f3c093e
Cr-Commit-Position: refs/heads/master@{#328413}

Powered by Google App Engine
This is Rietveld 408576698