Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 1113493002: Don't dispatch event after shutdown on AshWTHUnified (Closed)

Created:
5 years, 7 months ago by oshima
Modified:
5 years, 7 months ago
Reviewers:
Jun Mukai
CC:
chromium-reviews, sadrul, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, kalyank, danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't dispatch event after shutdown on AshWTHUnified in the same way as AshWTHX11/Ozone Fixed minor error introduced when cleaning up CL BUG=365662 TEST=UnifiedDesktopBasic will pass with real offscreen output surface Committed: https://crrev.com/b8fb0b710079b91da5b9e6172c723e16130cf7ff Cr-Commit-Position: refs/heads/master@{#327333}

Patch Set 1 : #

Total comments: 1

Patch Set 2 : #

Total comments: 3

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -8 lines) Patch
M ash/display/display_controller.cc View 1 2 2 chunks +17 lines, -6 lines 0 comments Download
M ash/display/mirror_window_controller.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M ash/host/ash_window_tree_host_unified.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
oshima
https://codereview.chromium.org/1113493002/diff/40001/ash/display/display_controller.cc File ash/display/display_controller.cc (right): https://codereview.chromium.org/1113493002/diff/40001/ash/display/display_controller.cc#newcode634 ash/display/display_controller.cc:634: if (switches::UnifiedDesktopEnabled()) { I made this change when cleaning ...
5 years, 7 months ago (2015-04-28 07:29:41 UTC) #4
Jun Mukai
https://codereview.chromium.org/1113493002/diff/60001/ash/display/display_controller.cc File ash/display/display_controller.cc (right): https://codereview.chromium.org/1113493002/diff/60001/ash/display/display_controller.cc#newcode635 ash/display/display_controller.cc:635: if (switches::UnifiedDesktopEnabled()) { Does this mean it's always in ...
5 years, 7 months ago (2015-04-28 17:07:39 UTC) #5
oshima
https://codereview.chromium.org/1113493002/diff/60001/ash/display/display_controller.cc File ash/display/display_controller.cc (right): https://codereview.chromium.org/1113493002/diff/60001/ash/display/display_controller.cc#newcode635 ash/display/display_controller.cc:635: if (switches::UnifiedDesktopEnabled()) { On 2015/04/28 17:07:39, Jun Mukai wrote: ...
5 years, 7 months ago (2015-04-28 17:10:18 UTC) #6
oshima
https://codereview.chromium.org/1113493002/diff/60001/ash/display/display_controller.cc File ash/display/display_controller.cc (right): https://codereview.chromium.org/1113493002/diff/60001/ash/display/display_controller.cc#newcode635 ash/display/display_controller.cc:635: if (switches::UnifiedDesktopEnabled()) { On 2015/04/28 17:10:18, oshima wrote: > ...
5 years, 7 months ago (2015-04-28 17:20:20 UTC) #7
Jun Mukai
lgtm
5 years, 7 months ago (2015-04-28 17:27:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1113493002/80001
5 years, 7 months ago (2015-04-28 17:28:33 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:80001)
5 years, 7 months ago (2015-04-28 18:25:16 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 18:26:59 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b8fb0b710079b91da5b9e6172c723e16130cf7ff
Cr-Commit-Position: refs/heads/master@{#327333}

Powered by Google App Engine
This is Rietveld 408576698