Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1113483002: App launcher: Added Finch experiment for the search ranking algorithm. (Closed)

Created:
5 years, 7 months ago by Matt Giuca
Modified:
5 years, 7 months ago
Reviewers:
calamity
CC:
chromium-reviews, tfarina, Matt Giuca, tapted, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@applist-mixer-debug-framework
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

App launcher: Added Finch experiment for the search ranking algorithm. Adds the "AppListMixer" Finch experiment, affecting the search result ranking and mixing in the App Launcher. By default, the mixer behaves exactly as before. With the "Blended" option, results are selected and ordered more naturally according to their relevance to the query, rather than in arbitrary groups ("apps, then omnibox, then webstore, then people"). Specific changes under the "Blended" option: - Replaced the per-group "boost" with a per-group "multiplier". Now, instead of stratifying results from each group, they are mixed together according to the relevance score assigned by the provider. Some groups have a multiplier to de-prioritize them (people results x0.85, webstore results x0.4). This means that relevance scores now need to be comparable between groups! - Removed the 6-result limit from the mixer. It can now return an arbitrary number of results, which will later be truncated by the view. (This is necessary because the view now supports more than 6 results, since all app results take up a single row.) - The per-group limit is now a "soft" limit. If there aren't enough total results to fill a minimum quota of 6, we go back and get as many results as we can from each group. - The omnibox group is no longer special. Previously, it had no limit, but would only provide more than 1 result if there was room. Now, it has a soft limit of 4, and behaves the same as other groups (can provide more results if necessary). Can be enabled with --force-fieldtrials=AppListMixer/Blended. BUG=487494, 460451, 422610, 338418 Committed: https://crrev.com/965f3753d607bc9322b96b85cb2319d5afbcfa90 Cr-Commit-Position: refs/heads/master@{#329601}

Patch Set 1 #

Patch Set 2 : Misc improvements. #

Patch Set 3 : Remove debugging. #

Patch Set 4 : Fix launcher search results. #

Patch Set 5 : Use range-based loops. #

Patch Set 6 : Misc improvements. #

Patch Set 7 : Tweak the tokenized string match so a 3-letter app match is above a search-what-you-typed. #

Patch Set 8 : Rebase. #

Total comments: 1

Patch Set 9 : Rebase off CL 1138193002. #

Patch Set 10 : Typo. #

Patch Set 11 : Remove kNoMaxResultsLimit. It isn't being used. #

Patch Set 12 : Change to a field trial (existing behaviour preserved by default). #

Total comments: 5

Patch Set 13 : Added TODO. #

Patch Set 14 : Split variable. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -64 lines) Patch
M chrome/browser/ui/app_list/search/search_controller_factory.cc View 1 2 3 4 5 6 7 8 9 10 11 4 chunks +16 lines, -10 lines 0 comments Download
M ui/app_list/search/mixer.h View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +12 lines, -5 lines 0 comments Download
M ui/app_list/search/mixer.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 9 chunks +106 lines, -38 lines 0 comments Download
M ui/app_list/search/mixer_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +9 lines, -5 lines 0 comments Download
M ui/app_list/search_controller.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +2 lines, -2 lines 0 comments Download
M ui/app_list/search_controller.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
Matt Giuca
OK here are all the "improvements" (hopefully) to the ranking algorithm I've got so far. ...
5 years, 7 months ago (2015-04-29 07:54:27 UTC) #5
Matt Giuca
5 years, 7 months ago (2015-04-29 07:54:49 UTC) #6
Matt Giuca
ptal We'll put in histograms (in a separate CL) before landing this.
5 years, 7 months ago (2015-05-05 08:14:22 UTC) #7
calamity
lg. CL description: "tapers off". Resolve the testing TODOs. https://codereview.chromium.org/1113483002/diff/220001/chrome/browser/ui/app_list/search/search_controller_factory.cc File chrome/browser/ui/app_list/search/search_controller_factory.cc (right): https://codereview.chromium.org/1113483002/diff/220001/chrome/browser/ui/app_list/search/search_controller_factory.cc#newcode37 chrome/browser/ui/app_list/search/search_controller_factory.cc:37: ...
5 years, 7 months ago (2015-05-12 07:29:14 UTC) #9
Matt Giuca
Reverted back to the default behaviour, and added the new behaviour behind a field trial. ...
5 years, 7 months ago (2015-05-13 02:21:25 UTC) #10
calamity
CL description needs an update. https://codereview.chromium.org/1113483002/diff/300001/ui/app_list/search/mixer.cc File ui/app_list/search/mixer.cc (right): https://codereview.chromium.org/1113483002/diff/300001/ui/app_list/search/mixer.cc#newcode26 ui/app_list/search/mixer.cc:26: const size_t kMaxResults = ...
5 years, 7 months ago (2015-05-13 03:17:24 UTC) #11
Matt Giuca
https://codereview.chromium.org/1113483002/diff/300001/ui/app_list/search/mixer.cc File ui/app_list/search/mixer.cc (right): https://codereview.chromium.org/1113483002/diff/300001/ui/app_list/search/mixer.cc#newcode26 ui/app_list/search/mixer.cc:26: const size_t kMaxResults = 6; On 2015/05/13 03:17:23, calamity ...
5 years, 7 months ago (2015-05-13 04:02:00 UTC) #12
calamity
lgtm. https://codereview.chromium.org/1113483002/diff/300001/ui/app_list/search/mixer.cc File ui/app_list/search/mixer.cc (right): https://codereview.chromium.org/1113483002/diff/300001/ui/app_list/search/mixer.cc#newcode173 ui/app_list/search/mixer.cc:173: if (IsBlendedMixerTrialEnabled()) { On 2015/05/13 04:02:00, Matt Giuca ...
5 years, 7 months ago (2015-05-13 05:12:25 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1113483002/330007
5 years, 7 months ago (2015-05-13 05:32:43 UTC) #15
commit-bot: I haz the power
Committed patchset #14 (id:330007)
5 years, 7 months ago (2015-05-13 07:11:02 UTC) #16
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 07:11:53 UTC) #17
Message was sent while issue was closed.
Patchset 14 (id:??) landed as
https://crrev.com/965f3753d607bc9322b96b85cb2319d5afbcfa90
Cr-Commit-Position: refs/heads/master@{#329601}

Powered by Google App Engine
This is Rietveld 408576698