Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1113463003: Inlining DeathData accessors, per earlier CR's comment (Closed)

Created:
5 years, 7 months ago by vadimt
Modified:
5 years, 7 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Inlining DeathData accessors, per earlier CR's comment. BUG=456354 Committed: https://crrev.com/9e0a3c19c221db002fdd5512b0d56dde675e005b Cr-Commit-Position: refs/heads/master@{#327350}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -34 lines) Patch
M base/tracked_objects.h View 1 chunk +10 lines, -8 lines 0 comments Download
M base/tracked_objects.cc View 1 chunk +0 lines, -26 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
vadimt
Pre-reviewers, please pre-review, so to say.
5 years, 7 months ago (2015-04-28 01:38:24 UTC) #2
Ilya Sherman
LGTM, thanks.
5 years, 7 months ago (2015-04-28 02:15:00 UTC) #3
Alexei Svitkine (slow)
lgtm
5 years, 7 months ago (2015-04-28 14:28:43 UTC) #5
vadimt
cpu@, please provide OWNER's approval
5 years, 7 months ago (2015-04-28 14:29:47 UTC) #7
cpu_(ooo_6.6-7.5)
lgtm
5 years, 7 months ago (2015-04-28 18:25:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1113463003/1
5 years, 7 months ago (2015-04-28 18:26:41 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-28 19:45:23 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9e0a3c19c221db002fdd5512b0d56dde675e005b Cr-Commit-Position: refs/heads/master@{#327350}
5 years, 7 months ago (2015-04-28 19:46:06 UTC) #12
vadimt
5 years, 7 months ago (2015-04-30 21:51:13 UTC) #13
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1118753003/ by vadimt@chromium.org.

The reason for reverting is: Suspecting this CL caused crashes
(https://code.google.com/p/chromium/issues/detail?id=483255)..

Powered by Google App Engine
This is Rietveld 408576698