Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Unified Diff: pkg/analyzer/lib/src/generated/engine.dart

Issue 1113423003: Remove AnalysisContext.refactoringUnsafeSources. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/context/context.dart ('k') | pkg/analyzer/test/generated/engine_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/generated/engine.dart
diff --git a/pkg/analyzer/lib/src/generated/engine.dart b/pkg/analyzer/lib/src/generated/engine.dart
index 50b8bca742861815cbf1125130b7bf6da08e7c00..965e11c7e138c529312485db21f9f7544f935fa9 100644
--- a/pkg/analyzer/lib/src/generated/engine.dart
+++ b/pkg/analyzer/lib/src/generated/engine.dart
@@ -394,13 +394,6 @@ abstract class AnalysisContext {
Stream<SourcesChangedEvent> get onSourcesChanged;
/**
- * Return a list containing all of the sources known to this context whose
- * state is neither valid or flushed. These sources are not safe to update
- * during refactoring, because we might not know all the references in them.
- */
- List<Source> get refactoringUnsafeSources;
-
- /**
* Return the source factory used to create the sources that can be analyzed
* in this context.
*/
@@ -1348,22 +1341,6 @@ class AnalysisContextImpl implements InternalAnalysisContext {
List<AnalysisTarget> get priorityTargets => prioritySources;
@override
- List<Source> get refactoringUnsafeSources {
- List<Source> sources = new List<Source>();
- MapIterator<Source, SourceEntry> iterator = _cache.iterator();
- while (iterator.moveNext()) {
- SourceEntry sourceEntry = iterator.value;
- if (sourceEntry is DartEntry) {
- Source source = iterator.key;
- if (!source.isInSystemLibrary && !sourceEntry.isRefactoringSafe) {
- sources.add(source);
- }
- }
- }
- return sources;
- }
-
- @override
SourceFactory get sourceFactory => _sourceFactory;
@override
@@ -7540,22 +7517,6 @@ class DartEntry extends SourceEntry {
return false;
}
- /**
- * Return `true` if this data is safe to use in refactoring.
- */
- bool get isRefactoringSafe {
- ResolutionState state = _resolutionState;
- while (state != null) {
- CacheState resolvedState = state.getState(RESOLVED_UNIT);
- if (resolvedState != CacheState.VALID &&
- resolvedState != CacheState.FLUSHED) {
- return false;
- }
- state = state._nextState;
- }
- return true;
- }
-
@override
SourceKind get kind => getValue(SOURCE_KIND);
« no previous file with comments | « pkg/analyzer/lib/src/context/context.dart ('k') | pkg/analyzer/test/generated/engine_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698