Issue 1113403002: This CL clean up patch in DeviceMotionEvent.

Issue 1113403002: This CL clean up patch in DeviceMotionEvent. (Closed)

Created:
5 years, 7 months ago by hyunjunekim2

Modified:
5 years, 7 months ago

Reviewers:
haraken, Mike West, pfeldman

CC:
blink-reviews, Inactive, mlamouri+watch-blink_chromium.org, mvanouwerkerk+watch_chromium.org, timvolodine

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

This CL clean up codes in DeviceMotionEvent. This Cl clean up codes. Replace 0 with nullptr in DeviceMotionEvent. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194813

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	Source/modules/device_orientation/DeviceMotionEvent.cpp	View		3 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 11 (4 generated)

hyunjunekim2

Hi, I'm hyunjunekim (hyunjune.kim@samsung.com, hykim0777@gamil.com). Could you check this? Thank you.

5 years, 7 months ago (2015-05-01 15:41:40 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1113403002/1

5 years, 7 months ago (2015-05-01 15:54:29 UTC) #5

Mike West

Before landing this, would you mind cleaning up the CL description? Perhaps: "Replace 0 with ...

5 years, 7 months ago (2015-05-01 16:14:21 UTC) #6

hyunjunekim2

On 2015/05/01 16:14:21, Mike West (traveling. slow.) wrote: > Before landing this, would you mind ...

5 years, 7 months ago (2015-05-01 16:48:01 UTC) #8

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1113403002/1

5 years, 7 months ago (2015-05-01 16:49:28 UTC) #10

commit-bot: I haz the power

5 years, 7 months ago (2015-05-01 17:25:21 UTC) #11

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194813