OOPIF: Specify previous sibling frames when creating new RenderFrames.

content/common/frame_messages.h

Index: content/common/frame_messages.h
diff --git a/content/common/frame_messages.h b/content/common/frame_messages.h
index 70870ab2f77d9c535b4b1eb73ce07755bfa00bbd..eeb1936252fa5ce5b019e0f006c0d103b2891e1d 100644
--- a/content/common/frame_messages.h
+++ b/content/common/frame_messages.h
@@ -298,6 +298,33 @@ IPC_STRUCT_BEGIN(FrameMsg_NewFrame_WidgetParams)
   IPC_STRUCT_MEMBER(bool, hidden)
 IPC_STRUCT_END()
 
+IPC_STRUCT_BEGIN(FrameMsg_NewFrame_Params)
+  // Specifies the routing ID of the new RenderFrame object.
+  IPC_STRUCT_MEMBER(int, routing_id)
+
+  // The new frame should be created as a child of the object
+  // identified by |parent_routing_id| or as top level if that is
+  // MSG_ROUTING_NONE.
+  IPC_STRUCT_MEMBER(int, parent_routing_id)
+
+  // Identifies the previous sibling of the new frame, so that the new frame is
+  // inserted into the correct place in the frame tree.  If this is
+  // MSG_ROUTING_NONE, the frame will be created as the first child of its
+  // parent frame.
+  IPC_STRUCT_MEMBER(int, previous_sibling_routing_id)
+
+  // If a valid |proxy_routing_id| is provided, the new frame will be
+  // configured to replace the proxy on commit.
+  IPC_STRUCT_MEMBER(int, proxy_routing_id)
+
+  // When the new frame has a parent, |replication_state| holds the new frame's
+  // properties replicated from the process rendering the parent frame, such as
+  // the new frame's sandbox flags.
+  IPC_STRUCT_MEMBER(content::FrameReplicationState, replication_state)
+
+  IPC_STRUCT_MEMBER(FrameMsg_NewFrame_WidgetParams, widget_params)

[nasko, 2015/05/04 17:16:56]

nit: Let's add a comment about what widget_params means. This way it is
consistent with the rest of the fields of this struct.

[alexmos, 2015/05/04 21:18:04]

Done.

+IPC_STRUCT_END()
+
 IPC_STRUCT_BEGIN(FrameHostMsg_OpenURL_Params)
   IPC_STRUCT_MEMBER(GURL, url)
   IPC_STRUCT_MEMBER(content::Referrer, referrer)
@@ -389,19 +416,8 @@ IPC_MESSAGE_ROUTED0(FrameMsg_DisownOpener)
 // commit, activation and frame swap of the current DOM tree in blink.
 IPC_MESSAGE_ROUTED1(FrameMsg_VisualStateRequest, uint64 /* id */)
 
-// Instructs the renderer to create a new RenderFrame object with |routing_id|.
-// The new frame should be created as a child of the object identified by
-// |parent_routing_id| or as top level if that is MSG_ROUTING_NONE.
-// If a valid |proxy_routing_id| is provided, the new frame will be configured
-// to replace the proxy on commit.  When the new frame has a parent,
-// |replication_state| holds properties replicated from the process rendering
-// the parent frame, such as the new frame's sandbox flags.
-IPC_MESSAGE_CONTROL5(FrameMsg_NewFrame,
-                     int /* routing_id */,
-                     int /* parent_routing_id */,
-                     int /* proxy_routing_id */,
-                     content::FrameReplicationState /* replication_state */,
-                     FrameMsg_NewFrame_WidgetParams /* widget_params */)
+// Instructs the renderer to create a new RenderFrame object.
+IPC_MESSAGE_CONTROL1(FrameMsg_NewFrame, FrameMsg_NewFrame_Params);

[nasko, 2015/05/04 17:16:56]

nit: /* params */

[alexmos, 2015/05/04 21:18:03]

Done.

 
 // Instructs the renderer to create a new RenderFrameProxy object with
 // |routing_id|. The new proxy should be created as a child of the object