Adds thunks for getting platform handles

Adds thunks for getting platform handles

BUG=none
TEST=none
R=viettrungluu@chromium.org

Committed: https://crrev.com/8f7386b022c30b46325f8c67ba4d04d33606103b
Cr-Commit-Position: refs/heads/master@{#327937}

Committed: https://crrev.com/ad518c89bae7f7012f39f79d0fdf277b4f1a6d1b
Cr-Commit-Position: refs/heads/master@{#327969}

[sky, 2015-05-01 15:33:51]

I can expose the equivalent of ScopedPlatformHandle later if we so desire.

[viettrungluu, 2015-05-01 17:05:51]

https://codereview.chromium.org/1113393002/diff/1/mojo/platform_handle/platfo...
File mojo/platform_handle/platform_handle_functions.h (right):

https://codereview.chromium.org/1113393002/diff/1/mojo/platform_handle/platfo...
mojo/platform_handle/platform_handle_functions.h:14: // Wraps |platform_handle|
in a MojoHandle so that it can trasported, returns
trasported -> transported

https://codereview.chromium.org/1113393002/diff/1/mojo/platform_handle/platfo...
mojo/platform_handle/platform_handle_functions.h:17: PLATFORM_HANDLE_EXPORT bool
MojoCreatePlatformHandleWrapper(
Note that this is dubious as a C API, since C90 doesn't have bool. (And for C99,
it's a complicated story, involving <stdbool.h> and _Bool, at which point one
might worry about compatibility with C++'s bool.

If you want to be consistent with other Mojo system primitives, you'd return a
MojoResult.

https://codereview.chromium.org/1113393002/diff/1/mojo/platform_handle/platfo...
File mojo/platform_handle/platform_handle_thunks.h (right):

https://codereview.chromium.org/1113393002/diff/1/mojo/platform_handle/platfo...
mojo/platform_handle/platform_handle_thunks.h:13: struct
MojoPlatformHandleThunks {
You might want to call this "MojoPlatformHandlePrivateThunks", to make it clear
that this is not part of the public API for standard, untrusted apps.

[sky, 2015-05-01 17:18:45]

https://codereview.chromium.org/1113393002/diff/1/mojo/platform_handle/platfo...
File mojo/platform_handle/platform_handle_functions.h (right):

https://codereview.chromium.org/1113393002/diff/1/mojo/platform_handle/platfo...
mojo/platform_handle/platform_handle_functions.h:14: // Wraps |platform_handle|
in a MojoHandle so that it can trasported, returns
On 2015/05/01 17:05:51, viettrungluu wrote:
> trasported -> transported

Done.

https://codereview.chromium.org/1113393002/diff/1/mojo/platform_handle/platfo...
mojo/platform_handle/platform_handle_functions.h:17: PLATFORM_HANDLE_EXPORT bool
MojoCreatePlatformHandleWrapper(
On 2015/05/01 17:05:51, viettrungluu wrote:
> Note that this is dubious as a C API, since C90 doesn't have bool. (And for
C99,
> it's a complicated story, involving <stdbool.h> and _Bool, at which point one
> might worry about compatibility with C++'s bool.
> 
> If you want to be consistent with other Mojo system primitives, you'd return a
> MojoResult.

Done.

https://codereview.chromium.org/1113393002/diff/1/mojo/platform_handle/platfo...
File mojo/platform_handle/platform_handle_thunks.h (right):

https://codereview.chromium.org/1113393002/diff/1/mojo/platform_handle/platfo...
mojo/platform_handle/platform_handle_thunks.h:13: struct
MojoPlatformHandleThunks {
On 2015/05/01 17:05:51, viettrungluu wrote:
> You might want to call this "MojoPlatformHandlePrivateThunks", to make it
clear
> that this is not part of the public API for standard, untrusted apps.

Done.

[viettrungluu, 2015-05-01 17:23:12]

LGTM w/nit

https://codereview.chromium.org/1113393002/diff/20001/mojo/platform_handle/pl...
File mojo/platform_handle/platform_handle_thunks.h (right):

https://codereview.chromium.org/1113393002/diff/20001/mojo/platform_handle/pl...
mojo/platform_handle/platform_handle_thunks.h:1: // Copyright 2015 The Chromium
Authors. All rights reserved.
nit: Maybe also name these file platform_handle_private_thunks.*?

[sky, 2015-05-01 17:31:31]

https://codereview.chromium.org/1113393002/diff/20001/mojo/platform_handle/pl...
File mojo/platform_handle/platform_handle_thunks.h (right):

https://codereview.chromium.org/1113393002/diff/20001/mojo/platform_handle/pl...
mojo/platform_handle/platform_handle_thunks.h:1: // Copyright 2015 The Chromium
Authors. All rights reserved.
On 2015/05/01 17:23:12, viettrungluu wrote:
> nit: Maybe also name these file platform_handle_private_thunks.*?

Done.

[sky, 2015-05-01 17:31:39]

The CQ bit was checked by sky@chromium.org

[sky, 2015-05-01 17:31:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
viettrungluu@chromium.org
Link to the patchset: https://codereview.chromium.org/1113393002/#ps40001
(title: "rename")

[commit-bot: I haz the power, 2015-05-01 17:33:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1113393002/40001

[commit-bot: I haz the power, 2015-05-01 18:06:10]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-05-01 18:07:11]

Patchset 3 (id:??) landed as
https://crrev.com/8f7386b022c30b46325f8c67ba4d04d33606103b
Cr-Commit-Position: refs/heads/master@{#327937}

[sky, 2015-05-01 18:21:12]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1123453003/ by sky@chromium.org.

The reason for reverting is: Broke build..

[sky, 2015-05-01 20:05:40]

I had to revert this because of a missing include on windows. I believe I've
sorted that out, so am going to reland.

[sky, 2015-05-01 20:05:50]

The CQ bit was checked by sky@chromium.org

[sky, 2015-05-01 20:05:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
viettrungluu@chromium.org
Link to the patchset: https://codereview.chromium.org/1113393002/#ps80001
(title: "fix windows")

[commit-bot: I haz the power, 2015-05-01 20:06:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1113393002/80001

[commit-bot: I haz the power, 2015-05-01 20:11:56]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-05-01 20:12:46]

Patchset 5 (id:??) landed as
https://crrev.com/ad518c89bae7f7012f39f79d0fdf277b4f1a6d1b
Cr-Commit-Position: refs/heads/master@{#327969}