Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1113353002: Roll breakpad and fix signal propagation for WebView crash handler (Closed)

Created:
5 years, 7 months ago by Primiano Tucci (use gerrit)
Modified:
5 years, 7 months ago
Reviewers:
Torne
CC:
chromium-reviews, android-webview-reviews_chromium.org, Mark Mentovai, cjhopman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll breakpad and fix signal propagation for WebView crash handler This applies the fix described in https://breakpad.appspot.com/6844002 to both Breakpad and the 2nd Android WebView crash handler (aw_crash_handler) aw_crash_handler, which is soon to be deprecated and incorporated in the breakpad microdump one, prints the version code upon a crash, reuses the same breakpad signal handling logic and, threrefore, requires the same fix. The following revision is pulled in by the breakpad roll: https://chromium.googlesource.com/external/google-breakpad/src/+/9fcbe255a64d39295ad5f1f15c0b92db3da83c0f BUG=483399 Committed: https://crrev.com/e5e3d99fedbb267b55b33376ff82eb244291579d Cr-Commit-Position: refs/heads/master@{#327921}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/common/aw_crash_handler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Primiano Tucci (use gerrit)
5 years, 7 months ago (2015-05-01 09:32:31 UTC) #2
Torne
lgtm
5 years, 7 months ago (2015-05-01 09:45:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1113353002/1
5 years, 7 months ago (2015-05-01 15:54:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-01 16:39:38 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-01 16:40:39 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e5e3d99fedbb267b55b33376ff82eb244291579d
Cr-Commit-Position: refs/heads/master@{#327921}

Powered by Google App Engine
This is Rietveld 408576698