Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 1113343002: ExtensionFunctionDispatcher should use base::Process::Current() if single process mode. (Closed)

Created:
5 years, 7 months ago by yoichio
Modified:
5 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ExtensionFunctionDispatcher should use base::Process::Current() if single process mode. Since #323179, ExtensionFunctionDispatcher has used base::Process::DeprecatedGetProcessFromHandle to callback: https://chromium.googlesource.com/chromium/src/+/f8d789c4558c7575f4d388d44730d18fdf157 72c However, base::Process::DeprecatedGetProcessFromHandle(handle) assumes |handle| is not current process handle. The assumption brakes if single process mode thus chrome can't start with the '--single-process' flag. BUG=477001 Committed: https://crrev.com/f71a0add64e543c7bb4cf59442b77ec5f3f6978e Cr-Commit-Position: refs/heads/master@{#328923}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M extensions/browser/extension_function_dispatcher.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
yoichio
5 years, 7 months ago (2015-05-01 07:49:04 UTC) #2
cpu_(ooo_6.6-7.5)
please use an extensions owner.
5 years, 7 months ago (2015-05-01 17:21:41 UTC) #3
cpu_(ooo_6.6-7.5)
on second thought this seems easy enough for me to review. lgtm
5 years, 7 months ago (2015-05-08 02:56:49 UTC) #4
cpu_(ooo_6.6-7.5)
lgtm
5 years, 7 months ago (2015-05-08 02:57:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1113343002/1
5 years, 7 months ago (2015-05-08 02:57:49 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-08 04:03:45 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-08 04:05:34 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f71a0add64e543c7bb4cf59442b77ec5f3f6978e
Cr-Commit-Position: refs/heads/master@{#328923}

Powered by Google App Engine
This is Rietveld 408576698