Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Unified Diff: components/search_engines/template_url_service.cc

Issue 1113333003: Don't create a new profile when cleaning up stale ephemeral profiles. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: fix? Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/search_engines/template_url_service.cc
diff --git a/components/search_engines/template_url_service.cc b/components/search_engines/template_url_service.cc
index 923fa557248e5806dda48f64eb23fcf2964009d9..935aa5fefa1c2ad85e801e256926f0e862ce5506 100644
--- a/components/search_engines/template_url_service.cc
+++ b/components/search_engines/template_url_service.cc
@@ -806,6 +806,11 @@ void TemplateURLService::Shutdown() {
web_data_service_->CancelRequest(load_handle_);
}
web_data_service_ = NULL;
+
+ // Notify observers so they can unregister themselves.
+ // TODO(bauerb): Observers shouldn't outlive this class; see
+ // https://crbug.com/483528.
+ on_loaded_callbacks_.Notify();
Bernhard Bauer 2015/05/05 11:36:58 You might wonder why this change is part of this C
Mike Lerman 2015/05/05 13:44:45 I was wondering why you had linked in 483528 ;) Al
}
syncer::SyncDataList TemplateURLService::GetAllSyncData(

Powered by Google App Engine
This is Rietveld 408576698