Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4489)

Unified Diff: chrome/browser/profiles/profile_manager_browsertest.cc

Issue 1113333003: Don't create a new profile when cleaning up stale ephemeral profiles. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: fix? Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/profiles/profile_manager_browsertest.cc
diff --git a/chrome/browser/profiles/profile_manager_browsertest.cc b/chrome/browser/profiles/profile_manager_browsertest.cc
index 43df0d4b63a5b991c7590ceebb84d7e508e193be..7273ce20da3f614129794114611abe4f31e2f93e 100644
--- a/chrome/browser/profiles/profile_manager_browsertest.cc
+++ b/chrome/browser/profiles/profile_manager_browsertest.cc
@@ -163,7 +163,7 @@ IN_PROC_BROWSER_TEST_F(ProfileManagerBrowserTest, DeleteSingletonProfile) {
EXPECT_FALSE(singleton_profile_path.empty());
base::RunLoop run_loop;
profile_manager->ScheduleProfileForDeletion(
- singleton_profile_path,
+ singleton_profile_path, false /* suppress_profile_creation */,
base::Bind(&OnUnblockOnProfileCreation, &run_loop));
// Run the message loop until the profile is actually deleted (as indicated
@@ -211,10 +211,12 @@ IN_PROC_BROWSER_TEST_F(ProfileManagerBrowserTest, DISABLED_DeleteAllProfiles) {
base::FilePath profile_path2 = cache.GetPathOfProfileAtIndex(1);
EXPECT_FALSE(profile_path1.empty());
EXPECT_FALSE(profile_path2.empty());
- profile_manager->ScheduleProfileForDeletion(profile_path1,
- ProfileManager::CreateCallback());
- profile_manager->ScheduleProfileForDeletion(profile_path2,
- ProfileManager::CreateCallback());
+ profile_manager->ScheduleProfileForDeletion(
+ profile_path1, false /* suppress_profile_creation */,
+ ProfileManager::CreateCallback());
+ profile_manager->ScheduleProfileForDeletion(
+ profile_path2, false /* suppress_profile_creation */,
+ ProfileManager::CreateCallback());
// Spin things so deletion can take place.
content::RunAllPendingInMessageLoop();
@@ -455,7 +457,8 @@ IN_PROC_BROWSER_TEST_F(ProfileManagerBrowserTest, DeletePasswords) {
ProfileManager* profile_manager = g_browser_process->profile_manager();
base::RunLoop run_loop;
profile_manager->ScheduleProfileForDeletion(
- profile->GetPath(), base::Bind(&OnUnblockOnProfileCreation, &run_loop));
+ profile->GetPath(), false /* suppress_profile_creation */,
+ base::Bind(&OnUnblockOnProfileCreation, &run_loop));
run_loop.Run();
PasswordStoreConsumerVerifier verify_delete;

Powered by Google App Engine
This is Rietveld 408576698