Don't create a new profile when cleaning up stale ephemeral profiles.

chrome/browser/profiles/profile_manager_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/command_line.h"
 #include "base/files/file_util.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/run_loop.h"
@@ skipping 47 matching lines @@
 
 using base::ASCIIToUTF16;
 using content::BrowserThread;
 
 namespace {
 
 // This global variable is used to check that value returned to different
 // observers is the same.
 Profile* g_created_profile;
 
+#if !defined(OS_ANDROID) && !defined(OS_CHROMEOS)
+void FailOnProfileCreation(Profile* profile, Profile::CreateStatus status) {
+  ADD_FAILURE();
+}
+#endif  // !defined(OS_ANDROID) && !defined(OS_CHROMEOS)
+
 class UnittestProfileManager : public ::ProfileManagerWithoutInit {
  public:
   explicit UnittestProfileManager(const base::FilePath& user_data_dir)
       : ::ProfileManagerWithoutInit(user_data_dir) {}
 
  protected:
   Profile* CreateProfileHelper(const base::FilePath& file_path) override {
     if (!base::PathExists(file_path)) {
       if (!base::CreateDirectory(file_path))
         return NULL;
@@ skipping 817 matching lines @@
   base::RunLoop().RunUntilIdle();
 
   EXPECT_EQ(2u, profile_manager->GetLoadedProfiles().size());
   EXPECT_EQ(2u, profile_manager->GetProfileInfoCache().GetNumberOfProfiles());
 
   // Set the active profile.
   PrefService* local_state = g_browser_process->local_state();
   local_state->SetString(prefs::kProfileLastUsed, profile_name1);
 
   // Delete the active profile.
-  profile_manager->ScheduleProfileForDeletion(dest_path1,
-                                              ProfileManager::CreateCallback());
+  profile_manager->ScheduleProfileForDeletion(
+      dest_path1, false /* suppress_profile_creation */,
+      ProfileManager::CreateCallback());
   // Spin the message loop so that all the callbacks can finish running.
   base::RunLoop().RunUntilIdle();
 
   EXPECT_EQ(dest_path2, profile_manager->GetLastUsedProfile()->GetPath());
   EXPECT_EQ(profile_name2, local_state->GetString(prefs::kProfileLastUsed));
 }
 
 TEST_F(ProfileManagerTest, LastProfileDeleted) {
   ProfileManager* profile_manager = g_browser_process->profile_manager();
   ASSERT_TRUE(profile_manager);
@@ skipping 10 matching lines @@
   base::RunLoop().RunUntilIdle();
 
   EXPECT_EQ(1u, profile_manager->GetLoadedProfiles().size());
   EXPECT_EQ(1u, profile_manager->GetProfileInfoCache().GetNumberOfProfiles());
 
   // Set it as the active profile.
   PrefService* local_state = g_browser_process->local_state();
   local_state->SetString(prefs::kProfileLastUsed, profile_name1);
 
   // Delete the active profile.
-  profile_manager->ScheduleProfileForDeletion(dest_path1,
-                                              ProfileManager::CreateCallback());
+  profile_manager->ScheduleProfileForDeletion(
+      dest_path1, false /* suppress_profile_creation */,
+      ProfileManager::CreateCallback());
   // Spin the message loop so that all the callbacks can finish running.
   base::RunLoop().RunUntilIdle();
 
   // A new profile should have been created
   const std::string profile_name2 = "Profile 1";
   base::FilePath dest_path2 = temp_dir_.path().AppendASCII(profile_name2);
 
   EXPECT_EQ(dest_path2, profile_manager->GetLastUsedProfile()->GetPath());
   EXPECT_EQ(profile_name2, local_state->GetString(prefs::kProfileLastUsed));
   EXPECT_EQ(dest_path2,
@@ skipping 32 matching lines @@
 
   // The Guest profile does not get added to the ProfileInfoCache.
   EXPECT_EQ(2u, profile_manager->GetLoadedProfiles().size());
   EXPECT_EQ(1u, profile_manager->GetProfileInfoCache().GetNumberOfProfiles());
 
   // Set the Guest profile as the active profile.
   PrefService* local_state = g_browser_process->local_state();
   local_state->SetString(prefs::kProfileLastUsed, guest_profile_name);
 
   // Delete the other profile.
-  profile_manager->ScheduleProfileForDeletion(dest_path1,
-                                              ProfileManager::CreateCallback());
+  profile_manager->ScheduleProfileForDeletion(
+      dest_path1, false /* suppress_profile_creation */,
+      ProfileManager::CreateCallback());
   // Spin the message loop so that all the callbacks can finish running.
   base::RunLoop().RunUntilIdle();
 
   // A new profile should have been created.
   const std::string profile_name2 = "Profile 1";
   base::FilePath dest_path2 = temp_dir_.path().AppendASCII(profile_name2);
 
   EXPECT_EQ(3u, profile_manager->GetLoadedProfiles().size());
-  EXPECT_EQ(1u, profile_manager->GetProfileInfoCache().GetNumberOfProfiles());
+  ASSERT_EQ(1u, profile_manager->GetProfileInfoCache().GetNumberOfProfiles());
   EXPECT_EQ(dest_path2,
       profile_manager->GetProfileInfoCache().GetPathOfProfileAtIndex(0));
 }
 
+TEST_F(ProfileManagerTest, DeleteStaleEphemeralProfile) {
+  ProfileManager* profile_manager = g_browser_process->profile_manager();
+  ASSERT_TRUE(profile_manager);
+
+  // Create a profile, don't load it yet.
+  const std::string profile_name1 = "New Profile 1";
+  base::FilePath dest_path1 = temp_dir_.path().AppendASCII(profile_name1);
+
+  ProfileInfoCache& cache = profile_manager->GetProfileInfoCache();
+  cache.AddProfileToCache(dest_path1, ASCIIToUTF16(profile_name1),
+                          ASCIIToUTF16(profile_name1), 0, std::string());
+  EXPECT_EQ(1u, cache.GetNumberOfProfiles());
+  EXPECT_EQ(0u, profile_manager->GetLoadedProfiles().size());
+
+  // Set it as the active profile.
+  PrefService* local_state = g_browser_process->local_state();
+  local_state->SetString(prefs::kProfileLastUsed, profile_name1);
+
+  // Delete the active profile.
+  profile_manager->ScheduleProfileForDeletion(
+      dest_path1, true /* suppress_profile_creation */,
+      base::Bind(&FailOnProfileCreation));
+  // Spin the message loop so that all the callbacks can finish running.
+  base::RunLoop().RunUntilIdle();
+
+  // A new profile should have been set as the last used profile, but not loaded
+  // yet.
+  const std::string profile_name2 = "Profile 1";

[Mike Lerman, 2015/05/05 13:44:45]

nit: variable is profile_name2, but the name is Profile 1. s/1/2 :)

[Bernhard Bauer, 2015/05/05 14:33:22]

Yes... except ProfileManager internally increases the profile names, and it
starts counting at 1 :)

I manually increased the profile number if ProfileManager. Alternatively, I
could try to match the behavior in Chrome and call the first profile "Default".
Or "Profile 0" for proper zero-based indexing? :-D

+  base::FilePath dest_path2 = temp_dir_.path().AppendASCII(profile_name2);
+
+  EXPECT_EQ(0u, profile_manager->GetLoadedProfiles().size());
+  EXPECT_EQ(0u, cache.GetNumberOfProfiles());
+  EXPECT_EQ(profile_name2, local_state->GetString(prefs::kProfileLastUsed));
+}
+
 TEST_F(ProfileManagerTest, ProfileDisplayNameResetsDefaultName) {
   if (!profiles::IsMultipleProfilesEnabled())
     return;
 
   // The command line is reset at the end of every test by the test suite.
   switches::EnableNewAvatarMenuForTesting(
       base::CommandLine::ForCurrentProcess());
 
   ProfileManager* profile_manager = g_browser_process->profile_manager();
   ProfileInfoCache& cache = profile_manager->GetProfileInfoCache();
@@ skipping 11 matching lines @@
   // Multiple profiles means displaying the actual profile names.
   const base::string16 profile_name2 = cache.ChooseNameForNewProfile(1);
   Profile* profile2 = AddProfileToCache(profile_manager,
                                         "path_2", profile_name2);
   EXPECT_EQ(profile_name1,
             profiles::GetAvatarNameForProfile(profile1->GetPath()));
   EXPECT_EQ(profile_name2,
             profiles::GetAvatarNameForProfile(profile2->GetPath()));
 
   // Deleting a profile means returning to the default name.
-  profile_manager->ScheduleProfileForDeletion(profile2->GetPath(),
-                                              ProfileManager::CreateCallback());
+  profile_manager->ScheduleProfileForDeletion(
+      profile2->GetPath(), false /* suppress_profile_creation */,
+      ProfileManager::CreateCallback());
   // Spin the message loop so that all the callbacks can finish running.
   base::RunLoop().RunUntilIdle();
   EXPECT_EQ(default_profile_name,
             profiles::GetAvatarNameForProfile(profile1->GetPath()));
 }
 
 TEST_F(ProfileManagerTest, ProfileDisplayNamePreservesCustomName) {
   if (!profiles::IsMultipleProfilesEnabled())
     return;
 
@@ skipping 25 matching lines @@
   // Multiple profiles means displaying the actual profile names.
   const base::string16 profile_name2 = cache.ChooseNameForNewProfile(1);
   Profile* profile2 = AddProfileToCache(profile_manager,
                                         "path_2", profile_name2);
   EXPECT_EQ(custom_profile_name,
             profiles::GetAvatarNameForProfile(profile1->GetPath()));
   EXPECT_EQ(profile_name2,
             profiles::GetAvatarNameForProfile(profile2->GetPath()));
 
   // Deleting a profile means returning to the original, custom name.
-  profile_manager->ScheduleProfileForDeletion(profile2->GetPath(),
-                                              ProfileManager::CreateCallback());
+  profile_manager->ScheduleProfileForDeletion(
+      profile2->GetPath(), false /* suppress_profile_creation */,
+      ProfileManager::CreateCallback());
   // Spin the message loop so that all the callbacks can finish running.
   base::RunLoop().RunUntilIdle();
   EXPECT_EQ(custom_profile_name,
             profiles::GetAvatarNameForProfile(profile1->GetPath()));
 }
 
 TEST_F(ProfileManagerTest, ProfileDisplayNamePreservesSignedInName) {
   if (!profiles::IsMultipleProfilesEnabled())
     return;
 
@@ skipping 33 matching lines @@
   // Multiple profiles means displaying the actual profile names.
   const base::string16 profile_name2 = cache.ChooseNameForNewProfile(1);
   Profile* profile2 = AddProfileToCache(profile_manager,
                                         "path_2", profile_name2);
   EXPECT_EQ(gaia_given_name,
             profiles::GetAvatarNameForProfile(profile1->GetPath()));
   EXPECT_EQ(profile_name2,
             profiles::GetAvatarNameForProfile(profile2->GetPath()));
 
   // Deleting a profile means returning to the original, actual profile name.
-  profile_manager->ScheduleProfileForDeletion(profile2->GetPath(),
-                                              ProfileManager::CreateCallback());
+  profile_manager->ScheduleProfileForDeletion(
+      profile2->GetPath(), false /* suppress_profile_creation */,
+      ProfileManager::CreateCallback());
   // Spin the message loop so that all the callbacks can finish running.
   base::RunLoop().RunUntilIdle();
   EXPECT_EQ(gaia_given_name,
             profiles::GetAvatarNameForProfile(profile1->GetPath()));
 }
 
 TEST_F(ProfileManagerTest, ProfileDisplayNameIsEmailIfDefaultName) {
   if (!profiles::IsMultipleProfilesEnabled())
     return;
 
@@ skipping 83 matching lines @@
   EXPECT_EQ(1u, profile_manager->GetLoadedProfiles().size());
   EXPECT_EQ(2u, cache.GetNumberOfProfiles());
 
   // Set the active profile.
   PrefService* local_state = g_browser_process->local_state();
   local_state->SetString(prefs::kProfileLastUsed,
                          dest_path1.BaseName().MaybeAsASCII());
 
   // Delete the active profile. This should switch and load the unloaded
   // profile.
-  profile_manager->ScheduleProfileForDeletion(dest_path1,
-                                              ProfileManager::CreateCallback());
+  profile_manager->ScheduleProfileForDeletion(
+      dest_path1, false /* suppress_profile_creation */,
+      ProfileManager::CreateCallback());
 
   // Spin the message loop so that all the callbacks can finish running.
   base::RunLoop().RunUntilIdle();
 
   EXPECT_EQ(dest_path2, profile_manager->GetLastUsedProfile()->GetPath());
   EXPECT_EQ(profile_name2, local_state->GetString(prefs::kProfileLastUsed));
 }
 
 // This tests the recursive call in ProfileManager::OnNewActiveProfileLoaded
 // by simulating a scenario in which the profile that is being loaded as
@@ skipping 36 matching lines @@
   local_state->SetString(prefs::kProfileLastUsed,
                          dest_path1.BaseName().MaybeAsASCII());
 
   // Delete the active profile, Profile1.
   // This will post a CreateProfileAsync message, that tries to load Profile2,
   // which checks that the profile is not being deleted, and then calls back
   // FinishDeletingProfile for Profile1.
   // Try to break this flow by setting the active profile to Profile2 in the
   // middle (so after the first posted message), and trying to delete Profile2,
   // so that the ProfileManager has to look for a different profile to load.
-  profile_manager->ScheduleProfileForDeletion(dest_path1,
-                                              ProfileManager::CreateCallback());
+  profile_manager->ScheduleProfileForDeletion(
+      dest_path1, false /* suppress_profile_creation */,
+      ProfileManager::CreateCallback());
   local_state->SetString(prefs::kProfileLastUsed,
                          dest_path2.BaseName().MaybeAsASCII());
-  profile_manager->ScheduleProfileForDeletion(dest_path2,
-                                              ProfileManager::CreateCallback());
+  profile_manager->ScheduleProfileForDeletion(
+      dest_path2, false /* suppress_profile_creation */,
+      ProfileManager::CreateCallback());
   // Spin the message loop so that all the callbacks can finish running.
   base::RunLoop().RunUntilIdle();
 
   EXPECT_EQ(dest_path3, profile_manager->GetLastUsedProfile()->GetPath());
   EXPECT_EQ(profile_name3, local_state->GetString(prefs::kProfileLastUsed));
 }
 #endif  // !defined(OS_MACOSX)