add deferred config to DM

add deferred config to DM

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/06a22f618cd2adbbd33634a701b5cf8353886d63

[reed1, 2015-05-05 14:38:26]

reed@google.com changed reviewers:
+ mtklein@google.com, robertphillips@google.com

[reed1, 2015-05-05 14:38:26]

ptal

[reed1, 2015-05-05 14:38:31]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-05-05 14:38:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1113273006/20001

[mtklein, 2015-05-05 14:45:31]

https://codereview.chromium.org/1113273006/diff/20001/dm/DMSrcSink.cpp
File dm/DMSrcSink.cpp (right):

https://codereview.chromium.org/1113273006/diff/20001/dm/DMSrcSink.cpp#newcod...
dm/DMSrcSink.cpp:598: // We turn ourselves into another Src that draws our
argument into bitmap/stream via pipe.
update / delete?

https://codereview.chromium.org/1113273006/diff/20001/dm/DMSrcSink.cpp#newcod...
dm/DMSrcSink.cpp:605: SkImageInfo info =
SkImageInfo::MakeN32Premul(size.width(), size.height());
Is it useful to have the deferred canvas match the color type of the ultimate
destination, or is this N32-is-good-enough-for-anyone?

https://codereview.chromium.org/1113273006/diff/20001/dm/DMSrcSink.cpp#newcod...
dm/DMSrcSink.cpp:608: return Error("can make surface for deferred canvas");
can -> can't?

https://codereview.chromium.org/1113273006/diff/20001/dm/DMSrcSink.cpp#newcod...
dm/DMSrcSink.cpp:612: if (err.isEmpty()) {
Seems like you're swallowing the error when it's not empty?

Error err = fSrc.draw(defcan);
if (!err.isEmpty()) {
  return err;
}
...
return "";

https://codereview.chromium.org/1113273006/diff/20001/dm/DMSrcSink.cpp#newcod...
dm/DMSrcSink.cpp:617: return Error("failed to create deferred image snapshot");
FYI, you can just write
  return "Failed to create deferred image snapshot.";

[robertphillips, 2015-05-05 14:45:42]

lgtm + typo

https://codereview.chromium.org/1113273006/diff/20001/dm/DMSrcSink.cpp
File dm/DMSrcSink.cpp (right):

https://codereview.chromium.org/1113273006/diff/20001/dm/DMSrcSink.cpp#newcod...
dm/DMSrcSink.cpp:597: Error ViaDeferred::draw(const Src& src, SkBitmap* bitmap,
SkWStream* stream, SkString* log) const {
update comment

[commit-bot: I haz the power, 2015-05-05 14:49:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-05 14:49:52]

Dry run: This issue passed the CQ dry run.

[reed1, 2015-05-05 14:55:25]

https://codereview.chromium.org/1113273006/diff/20001/dm/DMSrcSink.cpp
File dm/DMSrcSink.cpp (right):

https://codereview.chromium.org/1113273006/diff/20001/dm/DMSrcSink.cpp#newcod...
dm/DMSrcSink.cpp:597: Error ViaDeferred::draw(const Src& src, SkBitmap* bitmap,
SkWStream* stream, SkString* log) const {
On 2015/05/05 14:45:42, robertphillips wrote:
> update comment

Done.

https://codereview.chromium.org/1113273006/diff/20001/dm/DMSrcSink.cpp#newcod...
dm/DMSrcSink.cpp:598: // We turn ourselves into another Src that draws our
argument into bitmap/stream via pipe.
On 2015/05/05 14:45:30, mtklein wrote:
> update / delete?

Done.

https://codereview.chromium.org/1113273006/diff/20001/dm/DMSrcSink.cpp#newcod...
dm/DMSrcSink.cpp:605: SkImageInfo info =
SkImageInfo::MakeN32Premul(size.width(), size.height());
On 2015/05/05 14:45:30, mtklein wrote:
> Is it useful to have the deferred canvas match the color type of the ultimate
> destination, or is this N32-is-good-enough-for-anyone?

Good point, I think I can use the same "info"

https://codereview.chromium.org/1113273006/diff/20001/dm/DMSrcSink.cpp#newcod...
dm/DMSrcSink.cpp:608: return Error("can make surface for deferred canvas");
On 2015/05/05 14:45:30, mtklein wrote:
> can -> can't?

Done.

https://codereview.chromium.org/1113273006/diff/20001/dm/DMSrcSink.cpp#newcod...
dm/DMSrcSink.cpp:612: if (err.isEmpty()) {
On 2015/05/05 14:45:30, mtklein wrote:
> Seems like you're swallowing the error when it's not empty?
> 
> Error err = fSrc.draw(defcan);
> if (!err.isEmpty()) {
>   return err;
> }
> ...
> return "";

Done.

https://codereview.chromium.org/1113273006/diff/20001/dm/DMSrcSink.cpp#newcod...
dm/DMSrcSink.cpp:617: return Error("failed to create deferred image snapshot");
On 2015/05/05 14:45:30, mtklein wrote:
> FYI, you can just write
>   return "Failed to create deferred image snapshot.";

Acknowledged.

[reed1, 2015-05-05 14:56:07]

The CQ bit was checked by reed@google.com to run a CQ dry run

[reed1, 2015-05-05 14:56:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1113273006/#ps40001
(title: "update dox, use orig colortype")

[commit-bot: I haz the power, 2015-05-05 14:56:19]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1113273006/40001

[mtklein, 2015-05-05 14:57:40]

lgtm

[reed1, 2015-05-05 14:59:45]

The CQ bit was unchecked by reed@google.com

[reed1, 2015-05-05 14:59:52]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2015-05-05 15:00:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1113273006/40001

[reed1, 2015-05-05 15:00:19]

given I could copy from ViaPipe, this was wicked-easy to code up. Kudos to a
nice design.

[mtklein, 2015-05-05 15:02:06]

On 2015/05/05 15:00:19, reed1 wrote:
> given I could copy from ViaPipe, this was wicked-easy to code up. Kudos to a
> nice design.

Thanks.  I was just thinking, man that's a lot of boilerplate to have to copy
and paste... I've got a smaller lambda-based version brewing in my head.

[reed1, 2015-05-05 15:07:38]

assuming this works, we may want to augment some of the bots to run in this mode
-- I think it would have found my bug (yesterday) rather than me burning 16hours
of DEPS rolling attempts.

[commit-bot: I haz the power, 2015-05-05 15:11:38]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/06a22f618cd2adbbd33634a701b5cf8353886d63