Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 1113223003: Revert of Adds resource_provider::ResourceProvider (Closed)

Created:
5 years, 7 months ago by Dan Beam
Modified:
5 years, 7 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Adds resource_provider::ResourceProvider (patchset #3 id:40001 of https://codereview.chromium.org/1108403008/) Reason for revert: Broke compile: http://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN/builds/853/steps/compile/logs/stdio#error1 Original issue's description: > Adds resource_provider::ResourceProvider > > It's used to fetch resources for mojo apps. > > R=ben@chromium.org > > Committed: https://crrev.com/6de67f80026697580ed4cefa11a72193243bd4a0 > Cr-Commit-Position: refs/heads/master@{#328014} TBR=ben@chromium.org,sky@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/51c7082d7db5a5a3149a6e2abfe8388020a37373 Cr-Commit-Position: refs/heads/master@{#328021}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -668 lines) Patch
D components/resource_provider/BUILD.gn View 1 chunk +0 lines, -83 lines 0 comments Download
D components/resource_provider/DEPS View 1 chunk +0 lines, -7 lines 0 comments Download
D components/resource_provider/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D components/resource_provider/file_utils.h View 1 chunk +0 lines, -29 lines 0 comments Download
D components/resource_provider/file_utils.cc View 1 chunk +0 lines, -66 lines 0 comments Download
D components/resource_provider/file_utils_unittest.cc View 1 chunk +0 lines, -80 lines 0 comments Download
D components/resource_provider/main.cc View 1 chunk +0 lines, -13 lines 0 comments Download
D components/resource_provider/public/interfaces/BUILD.gn View 1 chunk +0 lines, -14 lines 0 comments Download
D components/resource_provider/public/interfaces/resource_provider.mojom View 1 chunk +0 lines, -18 lines 0 comments Download
D components/resource_provider/resource_provider_app.h View 1 chunk +0 lines, -46 lines 0 comments Download
D components/resource_provider/resource_provider_app.cc View 1 chunk +0 lines, -45 lines 0 comments Download
D components/resource_provider/resource_provider_apptest.cc View 1 chunk +0 lines, -146 lines 0 comments Download
D components/resource_provider/resource_provider_impl.h View 1 chunk +0 lines, -31 lines 0 comments Download
D components/resource_provider/resource_provider_impl.cc View 1 chunk +0 lines, -60 lines 0 comments Download
D components/test/data/resource_provider/dir/sample2 View 1 chunk +0 lines, -1 line 0 comments Download
D components/test/data/resource_provider/sample View 1 chunk +0 lines, -1 line 0 comments Download
M mandoline/app/desktop/launcher_process.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/BUILD.gn View 1 chunk +0 lines, -9 lines 0 comments Download
M mojo/mojo_application_package.gni View 2 chunks +8 lines, -11 lines 0 comments Download
M mojo/services/BUILD.gn View 3 chunks +0 lines, -3 lines 0 comments Download
M mojo/tools/data/apptests View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Dan Beam
Created Revert of Adds resource_provider::ResourceProvider
5 years, 7 months ago (2015-05-01 23:44:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1113223003/1
5 years, 7 months ago (2015-05-01 23:46:13 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-01 23:52:01 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-01 23:54:04 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/51c7082d7db5a5a3149a6e2abfe8388020a37373
Cr-Commit-Position: refs/heads/master@{#328021}

Powered by Google App Engine
This is Rietveld 408576698