Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Unified Diff: net/socket/socket_test_util.cc

Issue 1113203002: Convert DnsTransactionTest to use SequencedSocketData (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/dns/dns_transaction_unittest.cc ('K') | « net/socket/socket_test_util.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/socket_test_util.cc
diff --git a/net/socket/socket_test_util.cc b/net/socket/socket_test_util.cc
index cf033c245c3e86c8b5c427c2dc061e49172b7a3a..dfd3e633d531a8be170c60f4ed8ecefef13267f4 100644
--- a/net/socket/socket_test_util.cc
+++ b/net/socket/socket_test_util.cc
@@ -600,6 +600,10 @@ void SequencedSocketData::Reset() {
weak_factory_.InvalidateWeakPtrs();
}
+bool SequencedSocketData::WasDataWritten() const {
+ return helper_.write_index() > 0 || write_state_ != IDLE;
+}
+
bool SequencedSocketData::at_read_eof() const {
return helper_.at_read_eof();
}
@@ -1702,7 +1706,9 @@ MockUDPClientSocket::MockUDPClientSocket(SocketDataProvider* data,
peer_addr_ = data->connect_data().peer_addr;
}
-MockUDPClientSocket::~MockUDPClientSocket() {}
+MockUDPClientSocket::~MockUDPClientSocket() {
+ data_->set_socket(nullptr);
+}
int MockUDPClientSocket::Read(IOBuffer* buf,
int buf_len,
« net/dns/dns_transaction_unittest.cc ('K') | « net/socket/socket_test_util.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698