Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Unified Diff: content/browser/renderer_host/input/gesture_event_queue.h

Issue 1113143002: Restore simple fling status bookkeeping (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/input/gesture_event_queue.h
diff --git a/content/browser/renderer_host/input/gesture_event_queue.h b/content/browser/renderer_host/input/gesture_event_queue.h
index 304366802504d99ffc27b6658eada5df6f271322..208b2de457c9c56d3eb8f5cb1453e89a310a5558 100644
--- a/content/browser/renderer_host/input/gesture_event_queue.h
+++ b/content/browser/renderer_host/input/gesture_event_queue.h
@@ -73,12 +73,6 @@ class CONTENT_EXPORT GestureEventQueue {
// active scroll sequence, suppressing brief scroll interruptions.
// Zero by default (disabled).
base::TimeDelta debounce_interval;
-
- // Whether to filter unnecessary GestureFlingCancel events. Filtering should
- // be disabled if there may be content-targetting fling curves about which
- // the renderer is unaware (e.g., with Android WebView).
- // True by default.
- bool enable_fling_cancel_filtering;
};
// Both |client| and |touchpad_client| must outlive the GestureEventQueue.
@@ -99,8 +93,9 @@ class CONTENT_EXPORT GestureEventQueue {
blink::WebInputEvent::Type type,
const ui::LatencyInfo& latency);
- // Notify the queue that a gesture fling animation in the renderer has ended.
- void DidStopFlinging();
+ // Sets the state of the |fling_in_progress_| field to indicate that a fling
+ // is definitely not in progress.
+ void FlingHasBeenHalted();
// Returns the |TouchpadTapSuppressionController| instance.
TouchpadTapSuppressionController* GetTouchpadTapSuppressionController();
@@ -112,8 +107,6 @@ class CONTENT_EXPORT GestureEventQueue {
debouncing_deferral_queue_.empty();
}
- int active_fling_count() const { return active_fling_count_; }
-
void set_debounce_interval_time_ms_for_testing(int interval_ms) {
debounce_interval_ = base::TimeDelta::FromMilliseconds(interval_ms);
}
@@ -165,13 +158,9 @@ class CONTENT_EXPORT GestureEventQueue {
// The receiver of all forwarded gesture events.
GestureEventQueueClient* client_;
- // Whether to filter unnecessary GestureFlingCancel events.
- bool enable_fling_cancel_filtering_;
-
- // Whether there are any active flings in the renderer. As the fling
- // end notification is asynchronous, we use a count rather than a boolean
- // to avoid races in bookkeeping when starting a new fling.
- int active_fling_count_;
+ // True if a GestureFlingStart is in progress on the renderer or
+ // queued without a subsequent queued GestureFlingCancel event.
+ bool fling_in_progress_;
// True if a GestureScrollUpdate sequence is in progress.
bool scrolling_in_progress_;
« no previous file with comments | « content/browser/android/content_view_core_impl.cc ('k') | content/browser/renderer_host/input/gesture_event_queue.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698