Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 1113133006: Revert of Resolve references to "this" the same way as normal variables (Closed)

Created:
5 years, 7 months ago by wingo
Modified:
5 years, 7 months ago
CC:
v8-dev, Yang, Michael Starzinger, aperez, adamk
Base URL:
https://chromium.googlesource.com/v8/v8@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Resolve references to "this" the same way as normal variables (patchset #11 id:240001 of https://codereview.chromium.org/1097283003/) Reason for revert: nosnap failures Original issue's description: > Resolve references to "this" the same way as normal variables > > Make the parser handle references to "this" as unresolved variables, so the > same logic as for the rest of function parameters is used for the receiver. > Minor additions to the code generation handle copying the receiver to the > context, along with the rest of the function parameters. > > Based on work by Adrian Perez de Castro <aperez@igalia.com>;. > > BUG= > LOG=N > > Committed: https://crrev.com/18619d355192e2699203d12d9ebb9caea107b693 > Cr-Commit-Position: refs/heads/master@{#28236} TBR=rossberg@chromium.org,mstarzinger@chromium.org,dslomov@chromium.org,adamk@chromium.org,arv@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/1e4173d93a58ab72208d40c38b0a20d91c863a37 Cr-Commit-Position: refs/heads/master@{#28238}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -291 lines) Patch
M src/arm/full-codegen-arm.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M src/compiler/ast-graph-builder.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/ast-graph-builder.cc View 3 chunks +11 lines, -44 lines 0 comments Download
M src/contexts.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M src/heap/heap.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/ia32/full-codegen-ia32.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M src/parser.cc View 6 chunks +9 lines, -14 lines 0 comments Download
M src/runtime/runtime-debug.cc View 1 chunk +8 lines, -13 lines 0 comments Download
M src/runtime/runtime-scopes.cc View 3 chunks +3 lines, -17 lines 0 comments Download
M src/scopeinfo.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/scopes.h View 3 chunks +3 lines, -20 lines 0 comments Download
M src/scopes.cc View 5 chunks +32 lines, -40 lines 0 comments Download
M src/variables.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M test/mjsunit/debug-scopes.js View 1 chunk +0 lines, -4 lines 0 comments Download
D test/mjsunit/harmony/arrow-functions-this.js View 1 chunk +0 lines, -81 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
wingo
Created Revert of Resolve references to "this" the same way as normal variables
5 years, 7 months ago (2015-05-05 17:23:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1113133006/1
5 years, 7 months ago (2015-05-05 17:23:51 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-05 17:24:24 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-05 17:24:38 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1e4173d93a58ab72208d40c38b0a20d91c863a37
Cr-Commit-Position: refs/heads/master@{#28238}

Powered by Google App Engine
This is Rietveld 408576698