Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(774)

Issue 1113133002: Subzero: Also dump live-end info for stack vars under -asm-verbose. (Closed)

Created:
5 years, 7 months ago by Jim Stichnoth
Modified:
5 years, 7 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Also dump live-end info for stack vars under -asm-verbose. It's sometimes useful to know whether a use of a stack variable (as opposed to a physical register) is the last use of that variable. For example, in a code sequence like: movl %edx, 24(%esp) movl 24(%esp), %edx it would be nice to know whether the code sequence is merely bad (i.e., 24(%esp) will be used later), or horrible (i.e., this ends 24(%esp)'s live range). We add stack variables to the per-instruction live-range-end annotation, but not to the per-block live-in and live-out annotations, because the latter would clutter the output greatly while adding very little actionable information. BUG= https://code.google.com/p/nativeclient/issues/detail?id=4135 R=jvoung@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=4175b2a684c1bb9f6e148825dccc2641f0390b02

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -13 lines) Patch
M src/IceCfgNode.cpp View 3 chunks +16 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Jim Stichnoth
5 years, 7 months ago (2015-04-30 17:53:06 UTC) #2
jvoung (off chromium)
lgtm
5 years, 7 months ago (2015-04-30 18:33:24 UTC) #3
Jim Stichnoth
5 years, 7 months ago (2015-04-30 19:26:27 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4175b2a684c1bb9f6e148825dccc2641f0390b02 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698