Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1113043004: [Smart Lock] Extract the screenlock state to the proximity_auth component. (Closed)

Created:
5 years, 7 months ago by Ilya Sherman
Modified:
5 years, 7 months ago
Reviewers:
Tim Song
CC:
chromium-reviews, extensions-reviews_chromium.org, dzhioev+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Smart Lock] Extract the screenlock state to the proximity_auth component. BUG=483276 TEST=none R=tengs@chromium.org Committed: https://crrev.com/0c4d95cab330375899d54a593149936f41808c93 Cr-Commit-Position: refs/heads/master@{#329553}

Patch Set 1 #

Patch Set 2 : Format #

Total comments: 2

Patch Set 3 : Fix unit tests compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+250 lines, -271 lines) Patch
M chrome/browser/chromeos/login/easy_unlock/bootstrap_user_context_initializer.h View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/easy_unlock/bootstrap_user_context_initializer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc View 4 chunks +17 lines, -16 lines 0 comments Download
M chrome/browser/signin/easy_unlock_screenlock_state_handler.h View 5 chunks +4 lines, -41 lines 0 comments Download
M chrome/browser/signin/easy_unlock_screenlock_state_handler.cc View 1 9 chunks +63 lines, -58 lines 0 comments Download
M chrome/browser/signin/easy_unlock_screenlock_state_handler_unittest.cc View 1 2 26 chunks +81 lines, -122 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service.h View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service.cc View 6 chunks +21 lines, -25 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service_observer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/proximity_auth.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M components/proximity_auth/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A components/proximity_auth/screenlock_state.h View 1 2 1 chunk +53 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (8 generated)
Ilya Sherman
5 years, 7 months ago (2015-04-30 22:37:18 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1113043004/1
5 years, 7 months ago (2015-04-30 22:40:41 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1113043004/20001
5 years, 7 months ago (2015-04-30 22:43:54 UTC) #6
Tim Song
https://codereview.chromium.org/1113043004/diff/20001/components/proximity_auth/screenlock_state.h File components/proximity_auth/screenlock_state.h (right): https://codereview.chromium.org/1113043004/diff/20001/components/proximity_auth/screenlock_state.h#newcode10 components/proximity_auth/screenlock_state.h:10: // Possible states of the proximity auth feature. nit: ...
5 years, 7 months ago (2015-04-30 23:16:56 UTC) #7
Tim Song
lgtm
5 years, 7 months ago (2015-04-30 23:17:05 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/48468) linux_chromium_gn_chromeos_rel on ...
5 years, 7 months ago (2015-04-30 23:21:25 UTC) #10
Ilya Sherman
https://chromiumcodereview.appspot.com/1113043004/diff/20001/components/proximity_auth/screenlock_state.h File components/proximity_auth/screenlock_state.h (right): https://chromiumcodereview.appspot.com/1113043004/diff/20001/components/proximity_auth/screenlock_state.h#newcode10 components/proximity_auth/screenlock_state.h:10: // Possible states of the proximity auth feature. On ...
5 years, 7 months ago (2015-05-01 22:33:28 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1113043004/40001
5 years, 7 months ago (2015-05-01 22:36:20 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/53141)
5 years, 7 months ago (2015-05-02 00:06:07 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1113043004/40001
5 years, 7 months ago (2015-05-13 00:26:33 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-13 01:15:30 UTC) #19
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 01:16:07 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0c4d95cab330375899d54a593149936f41808c93
Cr-Commit-Position: refs/heads/master@{#329553}

Powered by Google App Engine
This is Rietveld 408576698