Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1113023002: IDL: Check method.visible for methods implemented in private script (Closed)

Created:
5 years, 7 months ago by Jens Widell
Modified:
5 years, 7 months ago
Reviewers:
haraken, vivekg
CC:
blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, arv+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

IDL: Check method.visible for methods implemented in private script When an interface has partial interfaces in modules/, methods declared in the partial interfaces are present in interface['methods'] for the Jinja templates to see, but with method['visible'] set to false, meaning code shouldn't be generated. This flag wasn't checked when the private script trampoline of a method implemented in private script was generated, leading to the trampoline being defined both in core/v8/V8Foo.cpp and modules/v8/V8FooPartial.cpp. BUG=341031 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194747

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -32 lines) Patch
M Source/bindings/templates/interface_base.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp View 1 chunk +0 lines, -31 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Jens Widell
PTAL Solves a problem encountered in https://codereview.chromium.org/1084923002/ when trying to add a partial interface extending ...
5 years, 7 months ago (2015-04-30 14:01:24 UTC) #2
vivekg
LGTM
5 years, 7 months ago (2015-04-30 14:07:18 UTC) #3
Jens Widell
On 2015/04/30 14:07:18, vivekg_ wrote: > LGTM Thanks!
5 years, 7 months ago (2015-04-30 14:08:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1113023002/1
5 years, 7 months ago (2015-04-30 14:09:02 UTC) #6
haraken
LGTM
5 years, 7 months ago (2015-04-30 14:15:54 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-04-30 15:50:54 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194747

Powered by Google App Engine
This is Rietveld 408576698