Allow sanitizer coverage to create *.sancov files when sandboxed

Allow sanitizer coverage to create *.sancov files when sandboxed

Due to sandbox restrictions and for the sake of code simplicity, we have
to specify the directory in two environment variables:
SANITIZER_COVERAGE_DIR=XXX
and
ASAN_OPTIONS=coverage=1:coverage_dir="XXX"

BUG=430156

[Timur Iskhodzhanov, 2015-04-30 14:25:46]

timurrrr@chromium.org changed reviewers:
+ cpu@chromium.org, jschuh@chromium.org

[Timur Iskhodzhanov, 2015-04-30 14:25:47]

Hi Carlos, Justin,
Can you please review tshi small change?

See
https://code.google.com/p/chromium/issues/detail?id=430156#c11
for the rationale.
--
Timur

[cpu_(ooo_6.6-7.5), 2015-05-01 17:18:58]

looks good, one issue:

https://codereview.chromium.org/1113013003/diff/1/content/common/sandbox_win.cc
File content/common/sandbox_win.cc (right):

https://codereview.chromium.org/1113013003/diff/1/content/common/sandbox_win....
content/common/sandbox_win.cc:369: .Append(L"*.sancov");
use the native environment function so you don't have to do all that scoped_ptr
+ utf16 conversion.

[Timur Iskhodzhanov, 2015-05-01 18:01:15]

Which one should I use?

пт, 1 мая 2015, 20:19,  <cpu@chromium.org>:

> looks good, one issue:
>
>
>
>
https://codereview.chromium.org/1113013003/diff/1/content/common/sandbox_win.cc
> File content/common/sandbox_win.cc (right):
>
>
>
https://codereview.chromium.org/1113013003/diff/1/content/common/sandbox_win....
> content/common/sandbox_win.cc:369
>
<https://codereview.chromium.org/1113013003/diff/1/content/common/sandbox_win....>:
> .Append(L"*.sancov");
> use the native environment function so you don't have to do all that
> scoped_ptr + utf16 conversion.
>
> https://codereview.chromium.org/1113013003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[cpu_(ooo_6.6-7.5), 2015-05-04 16:53:36]

https://msdn.microsoft.com/en-us/library/windows/desktop/ms683188%28v=vs.85%2...

[Timur Iskhodzhanov, 2015-05-04 18:25:13]

You probably mean ::GetEnvironmentVariableA specifically?

[cpu_(ooo_6.6-7.5), 2015-05-05 21:02:42]

no, that is what I am trying to avoid. On windows base::FilePath is wchar_t (16
bits) which is what GetEnvironmentVariable gives.