Issue 1112953003: Oilpan: fix webkit unit tests after r194688.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1112953003: Oilpan: fix webkit unit tests after r194688. (Closed)

Created:
5 years, 7 months ago by sof

Modified:
5 years, 7 months ago

Reviewers:
oilpan-reviews, haraken

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Oilpan: fix webkit unit tests after r194688. When a plugin element is detached, Oilpan dispose()s of the plugin container to clear out required references. Take that into account when checking for detached state in isRectTopmost(). TBR=oilpan-reviews BUG=476590 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194703

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	Source/web/WebPluginContainerImpl.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1112953003/1

5 years, 7 months ago (2015-04-30 05:46:36 UTC) #3

commit-bot: I haz the power

5 years, 7 months ago (2015-04-30 06:34:37 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194703

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages